Code Monkey home page Code Monkey logo

Comments (5)

WyriHaximus avatar WyriHaximus commented on August 26, 2024 1

That's a good question! I suppose users like to be able to opt in to changes in node version but I don't know why. I'm not an actions author myself.

As an action author this is the first time I've ran into this as well. Also this is the first time we've seen a major nodejs version bump wave going across the platform.

I suppose if nothing but the node version changes there's no need to bump major version. This also means no one needs to update their workflows.

At this point I've purely using this action from self hosted runners myself. And with those you often have to install nodejs and provide the version you want. So I get why we see purely the nodejs version bump as the reason to do a major new version. On GitHub's hosted runners this isn't an issue tho. So I'll go ahead and tag a new major version tomorrow.

from github-action-helm3.

WyriHaximus avatar WyriHaximus commented on August 26, 2024

@corneliusroemer Thanks fot the PR. Why the new major tho? (Purely out of interest since I've seen that pattern in recent weeks.)

from github-action-helm3.

WyriHaximus avatar WyriHaximus commented on August 26, 2024

P.S. Will hold off releasing until @corneliusroemer responds because I feel there is something I'm missing.

from github-action-helm3.

corneliusroemer avatar corneliusroemer commented on August 26, 2024

That's a good question! I suppose users like to be able to opt in to changes in node version but I don't know why. I'm not an actions author myself.

I suppose if nothing but the node version changes there's no need to bump major version. This also means no one needs to update their workflows.

from github-action-helm3.

WyriHaximus avatar WyriHaximus commented on August 26, 2024

Just released v4: https://github.com/WyriHaximus/github-action-helm3/releases/tag/v4.0.0

from github-action-helm3.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.