Code Monkey home page Code Monkey logo

Comments (6)

wustho avatar wustho commented on July 21, 2024

Oh, hmm, will look into that, pretty rare to find books with blockquote, so less books to test...

from epy.

3N4N avatar 3N4N commented on July 21, 2024

Any update on this? I can help if you want.

from epy.

wustho avatar wustho commented on July 21, 2024

Yes @3N4N , help would be so appreciated.

Just to give you heads up, there have been a major in project structure (from single module ./epy.py being broken down to package ./src/epy_reader/*). Because a single file with > 3000 lines is too big for LSP in development.

So, I think you might need to make a change in ./src/epy_reader/parser.py.

Currently I'm focusing on refactoring the structure, so everybody else can contribute easier. The current project sructure is temporary while I'm trying to refactor reader.py.

Thanks!

from epy.

3N4N avatar 3N4N commented on July 21, 2024

I'll wait for the refactor to be done before making changes. Til then I can hardcode one less row for blockquotes. Won't be a problem.

from epy.

wustho avatar wustho commented on July 21, 2024

@3N4N it's just one line? Can you make a PR for that? I'll look into it first, before continue refactoring (might take a little bit time and phases for refactoring)...

from epy.

3N4N avatar 3N4N commented on July 21, 2024

I was talking about this line:

epy/epy.py

Lines 1209 to 1210 in 6dd1860

elif self.isinde:
self.idinde.add(len(self.text) - 1)

Subtracting 2 instead of 1 fixes the issue. But by my understanding, 1 should be the correct number. Which means this fix is not actually a fix but a hack. A fix would have to locate the souce of the bug first.

If I find a legitimate solution, I'll open a PR.

from epy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.