image support? about epy HOT 9 OPEN

Hey there, sorry a lot going on. I think it will be supported in future, but not in short time...

from epy.

@SlidingHorn hold up, epy and https://github.com/wustho/epr already support image like you suggested, mate

As you can read in epr documentation https://github.com/wustho/epr#opening-an-image

from epy.

Hej, just a small thing that could be implemented pretty easily:
I use the terminal kitty, and I wrote a small patch which for open_media displays the images in the terminal:

def open_media(scr, name, bstr):
    sfx = os.path.splitext(name)[1]
    fd, path = tempfile.mkstemp(suffix=sfx)
    try:
        with os.fdopen(fd, "wb") as tmp:
            # tmp.write(epub.file.read(src))
            tmp.write(bstr)
        # run(VWR + " " + path, shell=True)
        subprocess.call(
+           "kitty +kitten icat --silent " + path,
            shell=True,
+ #          stdout=subprocess.DEVNULL,
+ #          stderr=subprocess.DEVNULL
        )
        k = scr.getch()
    finally:
        os.remove(path)
    return k

Works perfectly, you could add a --kitty option to enable this if you want to add it :)

from epy.

nice! i really like this program and its features ^~^ you did a great job on it

from epy.

Thanks, mate! Appreciate it. I actually tried to implement it then. Casually, by checking if my kitty terminal support displaying image. Indeed it display for a second, then flickered and the image is gone.

So I dont bother continue since I have other things going on. Maybe in future when someone else does PR or when I can commit again...

from epy.

Thanks, mate! Appreciate it. I actually tried to implement it then. Casually, by checking if my kitty terminal support displaying image. Indeed it display for a second, then flickered and the image is gone.

So I dont bother continue since I have other things going on. Maybe in future when someone else does PR or when I can commit again...

aw, thats really cool you got it working for even a second though! i do not have much coding knowledge at all, i should get into it more so i can help out in situations like these ;v; i hope the other things you are busyt with aswell goes well ^~^

from epy.

Thanks, mate! Appreciate it. I actually tried to implement it then. Casually, by checking if my kitty terminal support displaying image. Indeed it display for a second, then flickered and the image is gone.

So I dont bother continue since I have other things going on. Maybe in future when someone else does PR or when I can commit again...

If I could offer a suggestion:

Maybe instead of trying to render it inline within the terminal (e.g. via w3m or whatever other method), you could just have links as placeholders that will use xdg-open to open the image in the user's preferred image viewer.

Just a thought! I just installed epy earlier today, and I'm loving it so far.

from epy.

@SlidingHorn hold up, epy and https://github.com/wustho/epr already support image like you suggested, mate

As you can read in epr documentation https://github.com/wustho/epr#opening-an-image

I didn't know that! I'm golden then, lol

from epy.

from epy.