URGENT: Saving / displaying and editing entries with fieldgroups does not work about moodle-mod_datalynx HOT 6 CLOSED

Text is now saved. Problem with field of type picture.

from moodle-mod_datalynx.

TODO: Do not save empty fields in contents table (example: empty string). Delete those rows in DB instead or do not consider those entries as "existing entries" or data.

from moodle-mod_datalynx.

The assumption things have been "visible to user" is not a valid assumption and is one of the origins of this bug. The concept to ignore certain submitted data is very dangerous. All submitted data has to be analysed.
https://github.com/dasistwas/moodle-mod_datalynx/blob/0fddcff6bbcb6cba7ccd94adf5066cf8daea1300/entries_class.php#L753

The iterator does not work either as the foreach is not in line with $i ($i differs from actual line number in the nested foreach loop).

from moodle-mod_datalynx.

Better approach could be: delete content from db when no data is submitted for the field.

from moodle-mod_datalynx.

What does not work: Removing the teammembers with the JavaScript "Delete" button does not work. They still appear when saving the form.

Next step: Strategy for displaying and saving data in a solid way. Open for discussion:

Approach 1

1. Add integer field to datalynx_contents table named rowid or lineid
2. Store the line of the fieldgroup there
3. Make deletion of content therefore easier: delete datalanx_contents where fieldid, entryid, rowid

from moodle-mod_datalynx.

Rebuilt this as discussed.
We now process all data, collect where we do see empty fieldvalues and check if a line is completely empty.
If this is the case we remove all line contents from database.
I'm closing this to allow for more precise issue descriptions, filed issue is fixed.

from moodle-mod_datalynx.