Comments (7)
Perhaps we can put them behind a feature flag and keep them in experimental/unstable state
that would also be a option, should it be a default though? and if disabled, should the old code be generated?
from dsync.
That is to say: in the current version, this would only generate the paginate fn if some experimental flag was set. If we want to stabilize parts of these experiments in the future, we’ll put them behind specific flags or add them to the default set, according to our decision
so if i understand correctly, we will remove the .paginate
function from non-flag builds?
from dsync.
Using the read() function to fetch a record with a specific primary key is a good-enough use case, so perhaps another option is to remove the paginate() fn?
from dsync.
Using the read() function to fetch a record with a specific primary key is a good-enough use case, so perhaps another option is to remove the paginate() fn?
i would likely be in favor of removing .paginate
(and related things in #103), unless we make it explicit that the default paginate function is meant to paginate without a specific clause (table order).
as for the other functions, i think it is reasonable to have some CRUD functions based on the identifier(s)
from dsync.
Perhaps we can put them behind a feature flag and keep them in experimental/unstable state
from dsync.
Yeah, let’s leave it disabled by default.
That is to say: in the current version, this would only generate the paginate fn if some experimental
flag was set. If we want to stabilize parts of these experiments in the future, we’ll put them behind specific flags or add them to the default set, according to our decision
from dsync.
See #126 -- removed .paginate from default set and also introduced some experimental API behind advanced-queries
from dsync.
Related Issues (20)
- Change default for tsync HOT 1
- Improve Code generation HOT 4
- Roadmap (Suggestions) HOT 8
- The "use diesel::*" change causes breakage as this can have conflicts with database table names HOT 1
- Add `PartialEq` derive to generated "Update" structs
- Check clone() usage for experimental filters HOT 1
- The `diesel::Identifiable` trait is not derived for the table a foreign key refers to HOT 7
- What to do about `StructType::Form` HOT 1
- Publishing via CI HOT 17
- CI refactor HOT 2
- fix: incomplete generated code for pk HOT 2
- question: what is `async` feature for? HOT 2
- fix: allow optional `GenerationConfig` fields HOT 9
- Change `use crate::diesel::*;` import to be more specific and not require `crate::` HOT 9
- question: `belonging_to` HOT 7
- feat: `--async` option for compiled binary (CLI) HOT 4
- feat: support `#[derive(QueryableByName)]` HOT 2
- feat: custom derive as config HOT 1
- Simplify table config fetching logic HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dsync.