Code Monkey home page Code Monkey logo

Comments (7)

hasezoey avatar hasezoey commented on July 26, 2024 1

Perhaps we can put them behind a feature flag and keep them in experimental/unstable state

that would also be a option, should it be a default though? and if disabled, should the old code be generated?

from dsync.

hasezoey avatar hasezoey commented on July 26, 2024 1

That is to say: in the current version, this would only generate the paginate fn if some experimental flag was set. If we want to stabilize parts of these experiments in the future, we’ll put them behind specific flags or add them to the default set, according to our decision

so if i understand correctly, we will remove the .paginate function from non-flag builds?

from dsync.

Wulf avatar Wulf commented on July 26, 2024

Using the read() function to fetch a record with a specific primary key is a good-enough use case, so perhaps another option is to remove the paginate() fn?

from dsync.

hasezoey avatar hasezoey commented on July 26, 2024

Using the read() function to fetch a record with a specific primary key is a good-enough use case, so perhaps another option is to remove the paginate() fn?

i would likely be in favor of removing .paginate (and related things in #103), unless we make it explicit that the default paginate function is meant to paginate without a specific clause (table order).
as for the other functions, i think it is reasonable to have some CRUD functions based on the identifier(s)

from dsync.

Wulf avatar Wulf commented on July 26, 2024

Perhaps we can put them behind a feature flag and keep them in experimental/unstable state

from dsync.

Wulf avatar Wulf commented on July 26, 2024

Yeah, let’s leave it disabled by default.

That is to say: in the current version, this would only generate the paginate fn if some experimental flag was set. If we want to stabilize parts of these experiments in the future, we’ll put them behind specific flags or add them to the default set, according to our decision

from dsync.

Wulf avatar Wulf commented on July 26, 2024

See #126 -- removed .paginate from default set and also introduced some experimental API behind advanced-queries

from dsync.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.