Comments (4)
Agreed for now. Though I think "breaking the build" is the only way to really enforce things. If it's a manual process I have to run, personally I know I won't do it often. However, if it breaks the build I will fix it. I say we move forward with the big things for now, but I do think there's value in adding more checks to "breaking" status over time, as I believe things outside of that status will not be used.
from www.
I tend to agree, with one large BUT.
I'd rather get contributions, and fixup trivial stuff myself than discourage people because they write a doc and get told it has 15 things they need to fix. That balance may shift if we start getting snowed under with PRs...
from www.
Looks to me as though y'all are fundamentally in agreement: start with the critical handful of must-fixes, see how it goes, and expand iteratively as need arises.
We aren't suffering from a wave of PRs yet, are we?
Back to original issue: slightly paraphrased list:
WTD/RTD branding, yup yup
Discriminatory language: can we flag this one with suggestions for how to fix, at least for cases where one could read it as stupidity or carelessness at work (gendered pronouns, I'm looking at you -- or racial stereotypes, which are often culturally specific)
I'm guessing we'll need to tweak this one if we get global submissions. And it has the potential to be a bit tricky. Definitely needed, will just also need some thoughtful tending.
Does obscenity belong in its own category? Or is it a subset of the previous item?
from www.
I agree with whatever ya'll agree about. I don't panic if I see 15 things I need to fix in a PR, but maybe someone else will. Going with the herd on this one.
from www.
Related Issues (20)
- Broken links in RTD GA action HOT 4
- Better jinja errors HOT 5
- Improve YAML (and validation)
- Investigate using plausible for analytics HOT 5
- Fix up broken formatting on Quorum page
- Rename the 2021 template thing
- Text overflow on smaller screens HOT 2
- Add a site-map link to the home page for the mobile UX HOT 8
- Bug in speaker list code?
- Sort video archive by date + add portland 2023 HOT 2
- Incorrect Slack URL? HOT 4
- Restructure event speakers and sessions HOT 1
- Home button on 404 pages doesn't work HOT 1
- Look at making sponsor inclusion conditional on them existing
- Using different theme for survey results HOT 6
- Speaker social media pics
- Update rST link in /docs/guide/learn-git-contribute.rst
- Fix CI tech debt
- Refactor talk video pages (again) HOT 1
- API content is outdated HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from www.