Code Monkey home page Code Monkey logo

Comments (4)

ericholscher avatar ericholscher commented on September 14, 2024

Agreed for now. Though I think "breaking the build" is the only way to really enforce things. If it's a manual process I have to run, personally I know I won't do it often. However, if it breaks the build I will fix it. I say we move forward with the big things for now, but I do think there's value in adding more checks to "breaking" status over time, as I believe things outside of that status will not be used.

from www.

plaindocs avatar plaindocs commented on September 14, 2024

I tend to agree, with one large BUT.

I'd rather get contributions, and fixup trivial stuff myself than discourage people because they write a doc and get told it has 15 things they need to fix. That balance may shift if we start getting snowed under with PRs...

from www.

Bradamant3 avatar Bradamant3 commented on September 14, 2024

Looks to me as though y'all are fundamentally in agreement: start with the critical handful of must-fixes, see how it goes, and expand iteratively as need arises.

We aren't suffering from a wave of PRs yet, are we?

Back to original issue: slightly paraphrased list:
WTD/RTD branding, yup yup
Discriminatory language: can we flag this one with suggestions for how to fix, at least for cases where one could read it as stupidity or carelessness at work (gendered pronouns, I'm looking at you -- or racial stereotypes, which are often culturally specific)
I'm guessing we'll need to tweak this one if we get global submissions. And it has the potential to be a bit tricky. Definitely needed, will just also need some thoughtful tending.
Does obscenity belong in its own category? Or is it a subset of the previous item?

from www.

thatdocslady avatar thatdocslady commented on September 14, 2024

I agree with whatever ya'll agree about. I don't panic if I see 15 things I need to fix in a PR, but maybe someone else will. Going with the herd on this one.

from www.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.