Comments (6)
I'm not sure what the best fix is, but I agree hiding the output entirely isn't good!
from wren-cli.
Simply dropping the color escapes for this case to make use of the default foreground color
This seems most obvious and reasonable. It's also how pretty much every other REPL that prints colors behaves, including your shell.
from wren-cli.
Great, I'll submit a PR for that then.
from wren-cli.
Introducing a light/dark color scheme?
IMHO, introducing a light/dark color scheme might be a good way to solve this. I was going to report a similar situation myself, because the terminal on Ubuntu (maybe some other distros as well?) has a dark background, making the keywords highlighted in gray not really visible. On the other hand, we also have terminals with light backgrounds, so having 2 themes might be better. :-)
from wren-cli.
I guess since my PR was closed without any comment and so were all the other open ones, keeping this issue open is meaningless.
from wren-cli.
The PRs getting closed was an automated system github has in place, it wasn't intended and doesn't have any meaning.
from wren-cli.
Related Issues (20)
- Proposal: `File.basename` and `File.dirname`
- RFC: Consider using an actual Wren testing library
- Document auto-generation? Moving docs from `wren` to `wren-cli`? HOT 3
- What is the correct behavior of `Stdin.readLine`? HOT 1
- What is the correct behavior of `Stdin.readByte`?
- What is correct behavior of `Stdin.readCodepoint`?
- continue HOT 12
- ER: import from a specified location HOT 6
- [BUG] "Unhandled key-code [dec]: 8" on Backspace HOT 5
- Meta module only load in REPL HOT 1
- libuv is a problem HOT 11
- Failed to build: Error: conflicting types for โwriteโ; have โvoid(WrenVM *, const char *)โ HOT 5
- ANSI Color for gray comes up black on MacOS terminal HOT 3
- Add a dynamic link build with wren and libuv
- Does not build on FreeBSD HOT 1
- .
- Absolut import does not work. HOT 4
- Minour she bang issue (#! /bin/path/to/wrenc) not working properly
- Log.info allows only strings HOT 2
- Missing ChangeLog entry for 0.4.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wren-cli.