dotted keys cause tomllib to fail to parse Cargo.toml about cargo-bump HOT 6 CLOSED

tomllib has not had a release or commit to master in ~3 years. toml-edit was recommended by @gyscos in #9 as it is used in cargo-edit. I want to survey any other libraries that can fit the bill before committing to one, as this is the second time the library I was using has died.

from cargo-bump.

toml-rs was recommended here: #10 (comment)

from cargo-bump.

Going to start on this issue by building a test suite that is agnostic to the toml crate. Since the needs from the TOML crate are pretty specific (format preservation) but only has to read/update a single value it should be easy enough to build the different impls once I get the test suite built. Should have had a suite for a while anyway.

from cargo-bump.

927fb3d Adds a basic test suite and factors the tomllib usage into a single function. Next up build implementations using toml_edit and toml-rs

from cargo-bump.

Updated top post, toml-rs is not suitable at all, it doesn't preserve comments or formatting.

toml_edit mostly fits the bill, but omits the cases with whitespace in the headers. The ability to parse the cases that tomllib failed on makes up for that problem though.

Moving forward with toml_edit will have to 2.0 since the whitespace preservation is changing which may break some use cases

from cargo-bump.

4ce6ae3

Fixes this, uses toml_edit as was recommended (and an implementation provided by) @gycos. Didn't use their patch mostly because I had to refactor the code for testing first. Will pull in their other patch for pre-release and meta data before 2.0 release goes out

from cargo-bump.