Code Monkey home page Code Monkey logo

Comments (3)

dthenley avatar dthenley commented on June 2, 2024

While I do agree that the Asides title isn't going to be relevant at all for anybody project I do like that it is there and will keep the developer thinking to change it to what it will need to be used for. Maybe we can change it 'Asides' to 'Blog Sidebar' to give the user a better understanding when using a screen reader to navigate an unchanged wprig theme, while still leaving that placeholder for any developer to use in the future.

from wprig.

dthenley avatar dthenley commented on June 2, 2024

@LukaszJaro I think a good middle ground would be to make it just 'Sidebar' that way it comes non-opiniated but still gives better context then asides. I made a PR for it

from wprig.

LukaszJaro avatar LukaszJaro commented on June 2, 2024

Thanks @dthenley for looking into this. I still think it should be removed completely as even adding the hidden screen reader heading is still being opinionated.

In my case, the asides normally include a visible heading so I would not require a separate hidden screen reader heading. Currently asides are announced as role complementary, if you want to specifically label them best practice appears to be using aria-label:

<aside id="sidebar" aria-label="Sponsors">
  <!-- content -->
</aside>

Example of how this would look:

image

Leaving out the the hidden heading will probably be most helpful, especially since many will not remove it and may end up with duplicate headings resulting in screen reader noise.

Here's reference https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/complementary_role

from wprig.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.