Add Stylelint about wprig HOT 11 CLOSED

I need to test this out. Right now, PHPCS is running CSSLint on all CSS files.

from wprig.

@mor10 cool! It is awesome that CSS code right now is protected.

BTW, even CSS Lint author think that Stylelint is better ;)
https://twitter.com/slicknet/status/1012002688622399488

from wprig.

Always looking for improvements. Want to make a PR to wire this in, or do you want to wait for my experimentation?

from wprig.

@mor10 Stylelint needs a config (the same was as in ESLint, there is no default config, you must select rule manually or to use some community shared config). So it will be better to decide what rules are important for you.

But I will send you a PR with a code to use Stylelint in Gulp:

from wprig.

Here is PR with initial support: #45

What could be added:

• Mention Stylelint in the docs.
• Add stylelint-config-recommended-scss and lint Sass files in sass Gulp task. But in this case, we need to separate origin CSS files and compiled from Sass CSS files (to not lint Sass files twice).
• Stylelint could automatically fix some of the problems. Maybe we need to give a simple way to use this feature for users? Maybe pre-commit hook?
• Review WordPress Stylelint config. Maybe add some other rules like keep persist order of properties?

from wprig.

I took a stab at this in #56.

Stylelint could automatically fix some of the problems. Maybe we need to give a simple way to use this feature for users? Maybe pre-commit hook?

gulp-stylelint has an option to do fixes inline. I set it so it fixes what it can before writing the output CSS file. It might make more sense to update the source file rather than the destination though. Maybe this could be a new gulp task that can be added to scripts in package.json as npm run fix-styles or similar.

Add stylelint-config-recommended-scss and lint Sass files in sass Gulp task. But in this case, we need to separate origin CSS files and compiled from Sass CSS files (to not lint Sass files twice).

This should be doable now that #47 is merged as sass files get written to the same destination as CSS files rather than the CSS dev directory.

from wprig.

Review WordPress Stylelint config. Maybe add some other rules like keep persist order of properties?

If we keep with the current WordPress rules there are quite a few violations in dev/style.css (see the attached report).

wp-rig-stylelint-report-wordpress-coding-standards.txt

from wprig.

Merged with v1.1. Closing.

from wprig.

@mor10 what do you want to do about the existing coding standard violations in WP Rig? They are mostly in CSS

from wprig.

I thought they were fixed. If not, I'll get it sorted.

from wprig.

I believe all of this is now resolved. Closing.

from wprig.