Code Monkey home page Code Monkey logo

Comments (4)

mor10 avatar mor10 commented on May 17, 2024

@dingo-d Can you create a PR for this?

from wprig.

dingo-d avatar dingo-d commented on May 17, 2024

Sure thing, on it :)

EDIT:

Ok so I wanted to test it, but for some reason, it's not picking the WordPress-Themestandard in the phpcs.xml.dist file.

If anyone wants to test it, modify the composer with this:

{
    "name": "wprig/wprig",
    "description": "A progressive theme development rig for WordPress.",
    "type": "wordpress-theme",
    "license": "GPL-2.0",
    "require-dev": {
        "wp-coding-standards/wpcs": "dev-feature/theme-review-sniffs",
        "dealerdirect/phpcodesniffer-composer-installer": "^0.4.4",
        "wimg/php-compatibility": "^8.1"
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/WPTRT/WordPress-Coding-Standards"
        }
    ]
}

and in the phpcs.xml.dist modify the rules

<rule ref="WordPress"/>
<rule ref="WordPress-Core" />
<rule ref="WordPress-Docs" /> 
<rule ref="WordPress-Extra" />

and replace it with

<rule ref="WordPress-Theme" />

I'll see what could be the issue. In the meantime, I can submit the PR with updated composer.json and removed WordPress and WordPress-Core standards from the ruleset (so that VIP and Core are not included).

Once the new repository for the WordPress-Theme coding standards is created I will submit a new PR.

Thoughts?

from wprig.

mor10 avatar mor10 commented on May 17, 2024

WPCS was updated to 1.0.0 which means this is no longer relevant. Closing.

from wprig.

dingo-d avatar dingo-d commented on May 17, 2024

I'll create a PR once we defork the Theme coding standards

from wprig.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.