Code Monkey home page Code Monkey logo

Comments (4)

franz-josef-kaiser avatar franz-josef-kaiser commented on July 21, 2024

Point with this issue is that we apply the filters in the following order:

  • Core Class filter
  • Child Class filter
  • All fields filter
  • Field Type filter
  • Field ID filter

So where should we hook in?

from meta-box.

rilwis avatar rilwis commented on July 21, 2024

Actually, we've applied all 5 filters:

// This make 2 calls to child class and core class
$begin = self::apply_field_class_filters( $field, 'begin_html', '', $meta );

$begin = apply_filters( "rwmb_begin_html", $begin, $field, $meta );
$begin = apply_filters( "rwmb_{$field['type']}_begin_html", $begin, $field, $meta );
$begin = apply_filters( "rwmb_{$field['id']}_begin_html", $begin, $field, $meta );

So, I think the best approach is changing the begin_html() function.

from meta-box.

franz-josef-kaiser avatar franz-josef-kaiser commented on July 21, 2024

That's what I did with the plupload class: I added the function to the class, checked before the html was output and then - in case - returned nothing.

As far as I've thought, it would be easier to hook into some filter with priority 9 (default 10) and check for

// Removes the label completely & allows for full width fields
if ( ! isset( $field['name'] ) )
    return;
// Return empty label to presave the space the label would normally take
// This way we can align multiple fields in a meta box even if one got no label
if ( empty( $field['name'] ) )
    return '';

// Output label....

from meta-box.

rilwis avatar rilwis commented on July 21, 2024

You did it and I've just improved with this commit 6ca2e28

from meta-box.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.