Comments (3)
Can reproduce the issue here for elements below/above the fold when having 3 or more nested elements https://newer.rocketlabsqa.ovh/lrc_similive/
Here
<header> header in body totally atf
<div class="container"> div in header in body <div> div in div in header in body
<h1>Powerful Electrical LLC</h1> </div>
<nav>
<ul>
<li><a href="#about1">About Us</a></li>
<li><a href="#services1">Services</a></li>
<li><a href="#contact1">Contact</a></li>
</ul>
</nav>
</div>
end header in body
</header>
<div> div in body <div> another div in body <header> header in div in div in body<div>another div in header in div in div in body</div></header></div></div>
and here <div> div in body<section>section in div<footer>footer in section in div</footer></section></div>
from wp-rocket.
Reproduce the issue ✅
Yes
Identify the root cause ✅
The pattern here doesn't handle values on a same line well which is why it break some nested elements, rightly changing to this
/data-rocket-location-hash="[^"]*"/i
as suggested by @DahmaniAdame fix the problem.
Scope a solution ✅
Change regex pattern to /data-rocket-location-hash="[^"]*"/i
and add test
Estimate the effort ✅
[S]
from wp-rocket.
LGTM
from wp-rocket.
Related Issues (20)
- Update Action scheduler to 3.8.1 to prevent warning in specific scenario HOT 2
- Clear Performance Hints of this URL won't clear the home page qs
- Hosting cache not cleared when clearing Performance Hints for current URL HOT 2
- Performance Hints error: null passed to delete_by_url() when string expected
- Improve Codacy test result with specific group test
- 3.17: Beacon script isnot injected in the uncached page if URL have LRC and not have LCP
- 3.17: All hashes are saved to DB for LRC HOT 4
- Attempt to read property "id" on bool [...] AbstractQueries.php on line 63
- 3.17 - Bump rollback version HOT 1
- 3.17 - SaaS visits generate LRC entries in DB but without hashes HOT 6
- 'Clear performance Hints data' will not be displayed in the WPR admin dropdown menu when env is set to local
- 3.17: LRC style isnot added to used CSS when enable RUCSS HOT 2
- 3.17: Footer hash isnot added to LRC DB table HOT 3
- 3.17 - Make depth and type of LRC candidates filterable HOT 3
- Data for mobile URLs will no longer be present under ATF & LRC tables under specific steps
- Why to Add Query String with ver=? HOT 2
- Detect when forms are used on a page and set its cache lifetime to 10 hours or less
- 3.17 - LRC hashes must be injected when needed for SaaS visits
- 3.17: PHP Warning: preg_replace(): Compilation failed: regular expression is too large at offset 3296566 with large html
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wp-rocket.