Code Monkey home page Code Monkey logo

Comments (2)

Tabrisrp avatar Tabrisrp commented on July 24, 2024

Scope a solution ✅

Engine\Media\AboveTheFold\AJAX\Controller

in add_lcp_data()

  • use esc_url_raw() on the lcp/viewport src values
  • update tests

Engine\Media\AboveTheFold\Frontend\Controller

in generate_lcp_link_tag_with_sources()

  • use esc_url() for the src values in the href
  • update tests

For the long date for LCP/ATF, I'm not sure how we could limit by character. The string is generated using JSON encoding of an object, so we can't truncate the string itself (it would be malformed).

Estimate the effort ✅

Effort [S]

from wp-rocket.

Miraeld avatar Miraeld commented on July 24, 2024

Looks good to me

from wp-rocket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.