Code Monkey home page Code Monkey logo

Comments (8)

worldwildweb avatar worldwildweb commented on June 25, 2024 1

Would be nice to clear the Used CSS after a plugin update also
slack: https://wp-media.slack.com/archives/C08N8J6VC/p1697530071237479

from wp-rocket.

webtrainingwheels avatar webtrainingwheels commented on June 25, 2024 1

I'd personally prefer it to be manually triggered, but maybe we can show a notice to suggest it if needed (like we do with cache clearing after plugin updates). Regenerating the CSS is too time-consuming of a process and should only be done when absolutely necessary, IMO.

from wp-rocket.

tatof avatar tatof commented on June 25, 2024

Extra feature question:
Does the "clear used CSS" get triggered on a automatic theme update?

from wp-rocket.

tatof avatar tatof commented on June 25, 2024

I'm running one theme with updates on multiple websites 40+ and I would like to clear the Used CSS after I push a necessary theme update. Now I have to login to every client and press the clear button...

If there is a hook to trigger it from within my theme its also a solution :)

from wp-rocket.

piotrbak avatar piotrbak commented on June 25, 2024

@DahmaniAdame What do you think about this? Automatically clearing Used CSS after each theme/plugin update seems to be a huge waste of resources.

from wp-rocket.

tatof avatar tatof commented on June 25, 2024

@piotrbak CSS is one of the most important parts of a theme. Theme updates should trigger a regenerate of cache & used CSS.

Tor example: The theme developer fixed html of a button and needed to alter the CSS to maintain the styling. Theme update rolls out, Cache is deleted but Used CSS is not. Then you have a button with new html but broken styling. Don't think that's what you want.

from wp-rocket.

DahmaniAdame avatar DahmaniAdame commented on June 25, 2024

@piotrbak the risk is that if the update has a front-end change. That would result in a broken element.

A notification about the change to the customer with them taking action if necessary will do.

Just like with do when adding/removing a plugin. We prompt a message to ask the customer clear cache if they know there is a change on the frontend. That will reduce the risk of something breaking.

@tatof

CSS is one of the most important parts of a theme.

It's not always the case.

But I agree that we need to provide a clearer way to communicate the risk and help the customer take action.

from wp-rocket.

piotrbak avatar piotrbak commented on June 25, 2024

@DahmaniAdame So, when the currently used theme is updated, we should display a notice similar to this one?
image

from wp-rocket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.