Conflict with Advanced Ads plugin causes fatal error when viewing Popular tab in the Ad New plugins page about wp-rocket HOT 3 CLOSED

Reproducible since 3.14.3 (working fine on 3.14.2.1)
Note: The file that throws the error was changed in 3.14.3 at this PR #6029 (may help for fix)

from wp-rocket.

Reproduce the problem

Like it's been said in the first message.

Identify the root cause

As mentioned in the first message, the error lies here :

It appears that the plugin Advanced Ads comes as an object rather than an array like most of other plugins.

Scope a solution

To solve the issue, we can add a verification if the variable is an object or not, and cast it to array if it is:

foreach ( $result->plugins as $index => $plugin ) {
	if ( is_object( $plugin ) ) {
		$plugin = (array) $plugin;
	}
	if ( $slug === $plugin['slug'] ) {
		$move = $plugin;
		unset( $result->plugins[ $index ] );
		array_unshift( $result->plugins, $move );
	}
}

Development steps:

Effort estimation:

XS

Is a refactor needed in that part of the codebase?

No

from wp-rocket.

@Miraeld seems good to me.

from wp-rocket.