Refine RUCSS error reporting with meaningful messages and timestamps about wp-rocket HOT 4 CLOSED

Scope a solution

• Create submitted_at field in the RUCSS table

1. update
   inc/Engine/Optimization/RUCSS/Database/Row/UsedCSS.php
   inc/Engine/Optimization/RUCSS/Database/Schemas/UsedCSS.php
   inc/Engine/Optimization/RUCSS/Database/Tables/UsedCSS.php
   to add a nullable timestamp column submitted_at

FYI: similar to what was done in this PR

2. set the new column value to the current timestamp in
   

   wp-rocket/inc/Engine/Optimization/RUCSS/Database/Queries/UsedCSS.php

   Line 164 in 8f94841

   public function create_new_job( string $url, string $job_id, string $queue_name, bool $is_mobile = false ) {

   
   and
   

   wp-rocket/inc/Engine/Optimization/RUCSS/Database/Queries/UsedCSS.php

   Line 209 in 8f94841

   public function reset_job( int $id, string $job_id ) {

• store more info in the message column

the message column is a longtext so it will hold a lot of data.
in make_status_failed we need to concatenate to the previous value and formate it like the suggestion above
Y-m-d H:i:s {status_code}: {error_message};

• Replace "Bad Json"

1. Replace "Bad Json" in get_queue_job_status by: "No message. Defaulted in get_queue_job_status"
   

   wp-rocket/inc/Engine/Optimization/RUCSS/Frontend/APIClient.php

   Line 76 in 56895a8

   public function get_queue_job_status( $job_id, $queue_name, $is_home = false ) {

2. Replace "Bad Json" in add_to_queue by: "No message. Defaulted in add_to_queue"
   

   wp-rocket/inc/Engine/Optimization/RUCSS/Frontend/APIClient.php

   Line 25 in 56895a8

   public function add_to_queue( string $url, array $options ): array {

Estimate effort

Effort S

from wp-rocket.

Looks good, thanks.
Just an additional point for the concatenation in message:
make_status_failed is only called if retries >=3 in check_job_status. So in order to store messages for intermediary retires, we would need to add an else logic:

if ( $row_details->retries >= 3 ) {
				Logger::debug( 'RUCSS: Job failed 3 times for url: ' . $row_details->url );
				/**
				 * Unlock preload URL.
				 *
				 * @param string $url URL to unlock
				 */
				do_action( 'rocket_preload_unlock_url', $row_details->url );

				$this->used_css_query->make_status_failed( $id, strval( $job_details['code'] ), $job_details['message'] );

				return;
			}
else{
    $this->used_css_query->update_message($id, strval( $job_details['code'] ), $job_details['message'])
}

With update_message that is a new method that concatenates new data to the existing message.

from wp-rocket.

thanks, @MathieuLamiot I totally missed this one.
in that case, I suggest updating the message with the retries increment to cover the 408 cases too

from wp-rocket.

Sounds good, either in the increment_retries method, or in a dedicated method next to it. 👍

from wp-rocket.