When running wp doctor check with the <code class="no

Fails on older themes with the `--skip-themes` option about doctor-command HOT 2 CLOSED

nostamp commented on July 2, 2024

Fails on older themes with the `--skip-themes` option

from doctor-command.

Comments (2)

swissspidy commented on July 2, 2024

--skip-themes is a global argument in WP-CLI to skip loading the theme. However, the doctor check command deliberately forces WordPress to be loaded with a theme:

doctor-command/inc/class-command.php

Lines 304 to 356 in 1c46617

    
           	/** 
        
           	 * Runs through the entirety of the WP bootstrap process 
        
           	 */ 
        
           	private function load_wordpress_with_template() { 
        
           		global $wp_query; 
        
           		WP_CLI::add_wp_hook( 
        
           			'wp_redirect', 
        
           			function ( $to ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter 
        
           				ob_start(); 
        
           				debug_print_backtrace(); 
        
           				$message = ob_get_clean(); 
        
           				throw new Exception( 'Incomplete check execution. Some code is trying to do a URL redirect. Backtrace:' . PHP_EOL . $message ); 
        
           			}, 
        
           			1 
        
           		); 
        
           		WP_CLI::get_runner()->load_wordpress(); 
        
           		// Set up the main WordPress query. 
        
           		wp(); 
        
           		$interpreted = array(); 
        
           		foreach ( $wp_query as $key => $value ) { 
        
           			if ( 0 === stripos( $key, 'is_' ) && $value ) { 
        
           				$interpreted[] = $key; 
        
           			} 
        
           		} 
        
           		WP_CLI::debug( 'Main WP_Query: ' . implode( ', ', $interpreted ), 'doctor' ); 
        
           		// phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedConstantFound -- WordPress Core constant. 
        
           		define( 'WP_USE_THEMES', true ); 
        
           		add_filter( 
        
           			'template_include', 
        
           			static function ( $template ) { 
        
           				$display_template = str_replace( dirname( get_template_directory() ) . '/', '', $template ); 
        
           				WP_CLI::debug( "Theme template: {$display_template}", 'doctor' ); 
        
           				return $template; 
        
           			}, 
        
           			999 
        
           		); 
        
           		// Template is normally loaded in global scope, so we need to replicate 
        
           		foreach ( $GLOBALS as $key => $value ) { 
        
           			global ${$key}; // phpcs:ignore PHPCompatibility.Variables.ForbiddenGlobalVariableVariable.NonBareVariableFound -- Syntax is updated to compatible with php 5 and 7. 
        
           		} 
        
           		// Load the theme template. 
        
           		ob_start(); 
        
           		require_once ABSPATH . WPINC . '/template-loader.php'; 
        
           		ob_get_clean(); 
        
           	}

So the two are not really compatible.

While the command could be adapted to manually load the theme's functions.php in that case, it's probably much simpler to just document that it can't be used in combination with --skip-themes.

What's the reason you are using --skip-themes in this instance?

from doctor-command.

nostamp commented on July 2, 2024

Thank you for the response. I was unaware of the compatibility issues. That --skip-themes flag ended up working its way into my notes as I run other commands with --skip-themes --skip-plugins when checking some core things.

Thank you kindly for the information. I will update my notes and discontinue the use.

from doctor-command.

Recommend Projects

Fails on older themes with the `--skip-themes` option about doctor-command HOT 2 CLOSED

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	/**
	* Runs through the entirety of the WP bootstrap process
	*/
	private function load_wordpress_with_template() {
	global $wp_query;

	WP_CLI::add_wp_hook(
	'wp_redirect',
	function ( $to ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter
	ob_start();
	debug_print_backtrace();
	$message = ob_get_clean();
	throw new Exception( 'Incomplete check execution. Some code is trying to do a URL redirect. Backtrace:' . PHP_EOL . $message );
	},
	1
	);

	WP_CLI::get_runner()->load_wordpress();

	// Set up the main WordPress query.
	wp();

	$interpreted = array();
	foreach ( $wp_query as $key => $value ) {
	if ( 0 === stripos( $key, 'is_' ) && $value ) {
	$interpreted[] = $key;
	}
	}
	WP_CLI::debug( 'Main WP_Query: ' . implode( ', ', $interpreted ), 'doctor' );

	// phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedConstantFound -- WordPress Core constant.
	define( 'WP_USE_THEMES', true );

	add_filter(
	'template_include',
	static function ( $template ) {
	$display_template = str_replace( dirname( get_template_directory() ) . '/', '', $template );
	WP_CLI::debug( "Theme template: {$display_template}", 'doctor' );
	return $template;
	},
	999
	);

	// Template is normally loaded in global scope, so we need to replicate
	foreach ( $GLOBALS as $key => $value ) {
	global ${$key}; // phpcs:ignore PHPCompatibility.Variables.ForbiddenGlobalVariableVariable.NonBareVariableFound -- Syntax is updated to compatible with php 5 and 7.
	}

	// Load the theme template.
	ob_start();
	require_once ABSPATH . WPINC . '/template-loader.php';
	ob_get_clean();
	}