question about concat about stream-adventure HOT 7 CLOSED

May I suggest that either the question or the solution should be changed.

I actually wrote the correct solution and then still had to refer to the solution.js when I couldn't get any output to console without ^D to end the prog and only then it dumps to console.

I realise why now only after reading Max's comments about it only being a 'write' stream.

+1 to the concat docs not being clear to me that you couldn't pipe the stream.

Maybe a step that mentions this and some ideas on how to end it gracefully?

from stream-adventure.

concat-stream is only a writable stream, not a readable one meaning you can only pipe things into it, but it can't be piped anywhere

from stream-adventure.

so i should just print out the stream from concat?

from stream-adventure.

it looks like you are already doing that, but you are also piping concat-stream to process.stdout which isn't something it supports

from stream-adventure.

from within your reverse function, you could write to stdout like this: process.stdout.write(body);. However, that doesn't pass the verify step as the last line is piped as null instead of an empty string. I think the expected output doesn't match the description of the task because the description does say to write it to stdout, not simply to use console.log

from stream-adventure.

+1 the description of this task could use some work. The docs for concat-stream are not very useful in this case either :( https://github.com/maxogden/concat-stream

from stream-adventure.

I'm closing this since concat solution was updated to use process.stdout.write in a2fd01a, the problem description was updated to be more clear about concat-stream and what return in 6bcb767

Also there will be an exercise about writable streams (#240) for complement the doubts about using that.

from stream-adventure.