Comments (12)
Personally I see a lot of value in keeping the logo block separate
I meant in addition to, not instead of :)
from gutenberg.
Perhaps, though my hesitation is that this makes it confusing for most users — even if the URL control is only added when the link toggle is disabled.
This renders the logo block useless and instead requires an image block which won't add favicon support.
Why not add your site icon (i.e. favicon) then replace the site logo block with an image/link of your choice?
from gutenberg.
Perhaps, though my hesitation is that this makes it confusing for most users — even if the URL control is only added when the link toggle is disabled.
This renders the logo block useless and instead requires an image block which won't add favicon support.
Why not add your site icon (i.e. favicon) then replace the site logo block with an image/link of your choice?
I would say the link to homepage toggle has been used as a quick fix. As far as I’m aware this format isn’t consistent with any other blocks. We already have an excellent linking system which supports internal and external links. These are also used on image blocks. I’m not sure why this wouldn’t be added to the logo block.
You have correctly identified a temporary solution for this issue but I don’t believe that should be the recommend approach.
from gutenberg.
I’m not sure why this wouldn’t be added to the logo block.
Because site logos link to the homepage on nearly every website. :)
from gutenberg.
I’m not sure why this wouldn’t be added to the logo block.
Because site logos link to the homepage on nearly every website. :)
That’s an easy perspective to have now WordPress has fully fledged page builder. But WordPress (the blogging platform) has also commonly be used for micro sites. Such as blogs, events, job boards, recipe sites, small WooCommerce sites, running on sub-domains.
I do agree with your point I just don’t know why you would purposely limit functionality, and not follow an already established design pattern.
Would be interested to hear alternative perspectives on this topic.
from gutenberg.
Just to be clear, I'm not entirely opposed to this—I'm just keeping in mind the additional complexity it introduces by showing/hiding an alternate control for the link.
There's weight to consider if the majority of users would not necessarily benefit from an additional control, or feature.
Would be interested to hear alternative perspectives on this topic.
Agreed! @WordPress/gutenberg-design thoughts?
from gutenberg.
Brainstorming...
The current Site Logo controls are very constrained compared to other blocks.
We look at the purpose of each block and compare with other blocks and the purpose these have. Then look at controls of one block and how another similar block is handled. We work on adding consistency between blocks where it is natural to do so.
We can compare the Image block and the Site Logo block. Look at controls of the Image block in comparison with the Site Logo block.
Image block has a much wider toolbar compared to the Site Logo block. The Site Logo is usually fairly small and having a smaller toolbar helps because of the small space it is in. But should it have a Replace button, an alignment option and a link option added to the toolbar?
Adding a Replace button keeping the consistency with the Image block. Right away adding the word/button Replace would make the toolbar much wider.
Adding an Alignment icon. Would be by default not be selected (as in off). User would be able to align it left, center or right.
Adding a link option to where the default link goes to home but can be adjusted by the user.
Now in the Site Logo block. There is a toggle "Link image to home" Toggling this off could add a field to where one can add a custom link or leave blank for no link.
Toggling image to not link to home could add the option to link to another location.
Not filling in a custom link would then not link the Site Logo to go anywhere.
Btw Rich @richtabor
Use as site icon toggle option. The link "Site Icon settings" opens the customizer in a new tab. Here one can add the open in new window icon beside the link to show the user that the link opens in a new tab/window.
from gutenberg.
I'll echo Rich, that having the site logo's link be defined by the values set in Reading Settings in WordPress is likely going to be the most predictable user experience, and avoid complexity.
Though I want to also say, we could come back to this at a later time, for example once reading settings get revisited. That might be a better place to explore a holistic solution to this. Because keep in mind, there's not just the site logo block, there's also a "Home Link" in the navigation block. So changing what is defined as a "homepage" is risky to do on a per-block basis, it can easily get out of sync and confusing.
In the mean time, I'd echo the idea that an image with an aspect ratio applied can be a good solution, just like a custom "Home" link in navigation would.
from gutenberg.
I wonder if the Image block could entertain refs in the future. So you could tell an Image block to use the site logo, similar to how the Cover block can reference the featured image.
from gutenberg.
I wonder if the Image block could entertain refs in the future. So you could tell an Image block to use the site logo, similar to how the Cover block can reference the featured image.
Personally I see a lot of value in keeping the logo block separate. It adds a lot of future-proofing, knowing you can use this to return the site logo.
I’d also say as much as I’d like the logo to support a custom link I think it’s important to keep the UX as familiar as possible. I’m not sure an additional input field for the link based on the toggle status is correct.
Personally I’d have the logo block by default always link to the site homepage. But add the link to the logo block toolbar so it can be changed or completely removed if required.
from gutenberg.
I would like to just update this thread to mention that its not possible to include an image inside the navigation block. The impact of this decision means that you can't display the logo (image) on the mobile menu overlay without custom code.
Regardless of the discussion surrounding if you should be able to add a custom link to the site logo the proposed intermediary solution isn't viable.
from gutenberg.
I'd just like to update this thread to keep it maintained with WordPress releases.
The Site logo still offers a site icon option which is now covered under Settings > General. Potentially making this option redundant.
I'd also note using an Image instead of the site logo means the image doesn't render on the mobile menu, meaning you have no logo when the mobile menu is open/active.
from gutenberg.
Related Issues (20)
- Inserter: Tab-focus diverges from other tab-bars HOT 1
- Save theme style variation in options instead of in the custom global styles post
- Outline button variation not working with TT4 (and other themes) HOT 4
- Update block_header_area() to support other template parts HOT 1
- Theme CSS color vars do not update outside of canvas iframe HOT 3
- Block generated with @wordpress/create-block does not show in editor HOT 3
- Section Styles: unecessary additional CSS output HOT 3
- Resetting template part causes snackbar notification saying it's been deleted HOT 1
- Switching pages with command palette opens site editor even if user can't access it
- Update JSON schemas to use draft-07 HOT 2
- e2e-test-utils-playwright - RequestUtils - add support for extraHTTPHeaders
- Image block: caption persists when replacing image
- Not possible to paste hyperlink in a blog post with Firefox
- [WP6.6] Select all shortcut doesn't work in modal opened from the List View HOT 1
- Social Links in widgets area do not listen to certain block styles
- Unexpected alignment of Image block with block themes HOT 1
- Double time TT4, TT3 and TT1 theme is given in appearance
- Restore "Edit site" in Gutenberg plugin HOT 2
- Add support for `address` tag to group block
- [@wordpress/scripts] eslint has some deprecated modules.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gutenberg.