Code Monkey home page Code Monkey logo

Comments (10)

afercia avatar afercia commented on June 3, 2024 1

#55446 solves the accessibility and usability issue.
I'm not sure it fully solves the potential SEO issue. I'd like to hear thoughts from some SEO experts here.

from gutenberg.

afercia avatar afercia commented on June 3, 2024

Worth also mentioning that a Query Loop block with 'Enhanced pagination' can be added also to a normal post or page.

In this case, the post or page actually become an archive page with paginated pages. Still, the document title will not change and will always be the same across all paginated pages.

Tje URL will change, e.g.:

https://my-site.org/my-awesome-post/?query-1-page=1
https://my-site.org/my-awesome-post/?query-1-page=2
https://my-site.org/my-awesome-post/?query-1-page=3

The document title will stay the same for all paginated pages, e.g.:

<title>My awesome post – My site</title>

from gutenberg.

fabiankaegy avatar fabiankaegy commented on June 3, 2024

@afercia I think your last comment conflates two things. It has always been the case that the pagination added on a post / page that uses the query param based pagination doesn't update the page title.

So I think there are two issues here. One is a long standing one that you are now finding, and the other is a new introduction with 6.4 and the enhanced pagination.

The new issue is that enhanced pagination on archive templates where you use the inherit option doesn't update the document title.

from gutenberg.

afercia avatar afercia commented on June 3, 2024

It has always been the case that the pagination added on a post / page that uses the query param based pagination doesn't update the page title.

@fabiankaegy yes that is possible but I would say it's an edge case. Worth improving it though.

The main issue here is about the archive pages. With SEO impact still to fully evaluate.

from gutenberg.

afercia avatar afercia commented on June 3, 2024

It has always been the case that the pagination added on a post / page that uses the query param based pagination doesn't update the page title.

I see a substantial difference between the situation with classic themes and block-based themes though.

Before:
adding some archive-like pagination to post / page and attempt to uses the query param based pagination was essentially a task for theme plugin developers. As developers, they had the technical skills to take care of the document title, if they wanted.

Now:
Users can and a Query Loop block and the Pagination block everywhere. As such, WordPress should make sure that it works correctly everywhere, updating the document title when necessary.

from gutenberg.

fabiankaegy avatar fabiankaegy commented on June 3, 2024

I see a substantial difference between the situation with classic themes and block-based themes though.

Before: adding some archive-like pagination to post / page and attempt to uses the query param based pagination was essentially a task for theme plugin developers. As developers, they had the technical skills to take care of the document title, if they wanted.

Now: Users can and a Query Loop block and the Pagination block everywhere. As such, WordPress should make sure that it works correctly everywhere, updating the document title when necessary.

I don't think I understand where you are drawing the line here. Regardless of whether you are in a block theme or in a classic theme that uses the block editor. You can insert a query block on any post / page in either. Which always has the query parameter based pagination which doesn't update the title.

So the issue is the same for all kinds of themes. This issue is fundamental to the Query block.

And the addition of "enhanced pagination" doesn't change anything about that.

The only difference with block based themes is that you can now also use the query block on archive pages and therefore use that actual /page/ based pagination. Before adding the "enhanced pagination" feature this did update the title correct. But now with the enhanced pagination the title is not updated correctly when the inherit option is selected.

from gutenberg.

afercia avatar afercia commented on June 3, 2024

I don't think I understand where you are drawing the line here.

When I mentioned 'classic' themes and block-based themes, I meant 'classic' as in: the traditional themes where pagination is managed by WordPres stemplating functions and users can't mess with the Query Loop.

Before adding the "enhanced pagination" feature this did update the title correct. But now with the enhanced pagination the title is not updated correctly when the inherit option is selected.

I think it doesn't update correctly also wjen inherit is disabled annd a custom query runs. Regardless, 'enhanced pagination' breaks a native browsers feature. Or, better, it males it unusable which is something that seems less than ideal to me.

As I mentioned, there's also potential SEO concerns here still to be fully evaluated.

from gutenberg.

c4rl0sbr4v0 avatar c4rl0sbr4v0 commented on June 3, 2024

Would be the enhanced pagination issue solved with this PR?

#55446

from gutenberg.

c4rl0sbr4v0 avatar c4rl0sbr4v0 commented on June 3, 2024

I'm not a SEO expert, but I guess when robots access different pages, they do a navigation per page, instead of clicking on the different pagination links. In that case all pages have their own urls and can be crawled, so should not be a problem.

from gutenberg.

afercia avatar afercia commented on June 3, 2024

I'm not an SEO expert so I'm not going to make assumptions about things I'm not 100% familiar with.
Just noting that it's not only about crawling, It's also about the Search results.

Anyways, it is important to take into consideration WordPress core has a few filters in place in the code that generates the document title. With Enhanced pagination enabled, these filters will keep returning the value generated via PHP on first page load as expected, but the value will not change when clicking the Enhanced pagination links. Basically these filters won't work and there's no equivalent implementation with Enhanced pagination enabled.
Plugins do use these filters to handle the title, description, opengraph tags and schemas. Also, the lack of the pagination related query_var(s) does have an impact and I'm not sure it has been fully evaluated.

Right now, while the document title is updated with the page number, other tags generated by plugins don't get the correct page number as they expect the WP filters to just work.

I'd think that at the very least the WordPress 6.4 Field Guid should put this problem in big relevance.
Ideally, an equivalent JS implementation to the core filters should have been provided.

Screenshot 2023-10-26 at 14 49 55

Cc @enricobattocchi

from gutenberg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.