Svelte grammar having issues with parsing if script tag declares language as `lang="ts"` about starry-night HOT 6 CLOSED

Hey @wooorm thank you very much for your work and your constant feedback.

Also, it seems a bit weird that GH is using this fork, which hasn’t been updated in 4 years, instead of the upstream from Svelte? Maybe that received updates and can be switched back in linguist?

Yes this is weird indeed, AFAIC see, they are looking to change to the upstream from Svelte but there are some things that aren't currently working as they suppose, and there aren't any updates from the upstream Svelte repo either.

See github-linguist/linguist#6215 (reply in thread)

from starry-night.

Hmm ok, thanks for working on this. Well, closing as this is tracked, and has to be solved, upstream!

from starry-night.

Thanks for letting me know! And cool to see you improving grammars, but also GitHub and this project!

I’m not sure how many of these PRs you’ll do, so I am not sure how many issues you’re planning on raising here either. I appreciate being notified but I don’t think tracking a separate issue for each here is needed: when things are accepted, they’ll be pulled into linguist, and then I’ll pull them into this project!

from starry-night.

Also, it seems a bit weird that GH is using this fork, which hasn’t been updated in 4 years, instead of the upstream from Svelte? Maybe that received updates and can be switched back in linguist?

from starry-night.

Hmm, see also github-linguist/linguist#5963 and github-linguist/linguist#6194

from starry-night.

And, also relating to your earlier JS issues, you’ll see that Svelte (which is pretty lights) does use the pretty lights JS bundle, which has those const ... ;s as blue: github-linguist/linguist#6194 (comment). So that’s a good way to test what GH is doing in pretty lights: embed it in Svelte or so.

from starry-night.