Code Monkey home page Code Monkey logo

Comments (6)

wooorm avatar wooorm commented on May 22, 2024

What does that commit break?
All these packages are used a lot in electron, and by folks who have no clue about Node.js/JavaScript, so im delaying this project

from dictionaries.

remcohaszing avatar remcohaszing commented on May 22, 2024
  • It introduces let syntax, which breaks compatibility with node 0.12
  • It introduces arrow functions, which breaks compatibility with node 0.12
  • It changes the fallback values of exception and result from null to undefined. Although technically this isn’t a breaking change, because an exception can never occur while reading the aff and dic files.

I personally don’t care for such old Node.js versions, but given the initial release date of this project and the lack of an engines field and Compatibility section in the readme, those are technically breaking changes.

from dictionaries.

wooorm avatar wooorm commented on May 22, 2024

Node 0.12 and this project are both 7 years old. I don’t really see this problem

from dictionaries.

wooorm avatar wooorm commented on May 22, 2024

Compared to the ESM problem, which is definitely a major

from dictionaries.

remcohaszing avatar remcohaszing commented on May 22, 2024

If electron support is really important, but old Node.js version support isn't, then never mind this issue 🙂

from dictionaries.

wooorm avatar wooorm commented on May 22, 2024

A lot of folks are getting these dictionaries by manually downloading them and placing the files somewhere. They often don’t know about Node, npm, or JavaScript.

from dictionaries.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.