Sparse field sets return empty arrays for null attributes (shouldn't it be empty hashes)? about yin HOT 5 CLOSED

I am not sure about this issue: I tested the sparse fieldset and inclusion functionality with my book example and with another project of mine, but they both worked well. I couldn't make Yin fail with any queries I came up with and it even worked with 2 level deep relationships.

Could you show me an actual query and its response? If it is not possible, could you double check your settings?

from yin.

Let me try to put together a test case..

from yin.

Ok, I'll chalk this one up to user error.

However I think I may have discovered a very minor issue.

The json returned for null attributes is a null array, but in the link I referenced it seems to show null hashes:

http://discuss.jsonapi.org/t/clarification-on-the-sparse-fieldset-response/221/2

Test Url:

curl --url "http://localhost:4000/examples/index.php?example=book&id=1&include=authors,publisher,publisher.representative&fields\[book\]="

Response:

{"jsonApi":{"version":"1.0"},"links":{"self":"\/books\/1"},"data":{"type":"book","id":"1","links":{"self":"\/books\/1"},"attributes":[],"relationships":[]}, ....

from yin.

I am glad that it was only user error. :)

The other issue stands because Yin uses arrays internally to store the document and json_encode converts empty arrays to JSON arrays. Tell me if you know a workaround for this phenomenon. :)

However, according to the discussion you linked, a possible easy fix would be to omit these keys altogether when empty. I'll implement it!

from yin.

I am closing the issue as the problem should be fixed in v0.10.1! Feel free to reopen the bug if you think otherwise.

from yin.