Windows support about ff2mpv HOT 12 CLOSED

In its current state, probably not. Sorry!

I don't own a Windows machine and have no way of developing/testing for Windows. It's something I'd accept a PR for, though.

from ff2mpv.

@ tp78903

{
    "name": "ff2mpv",
    "description": "ff2mpv's external manifest",
    "path": "C:\python3.exe ff2mpv.py",
    "type": "stdio",
    "allowed_extensions": ["[email protected]"]
}

from ff2mpv.

@b4zz4 Would you consider making a PR for that, in the form of a new file (e.g., ff2mpv.windows.json?)

from ff2mpv.

i dont have window 👎 . But aca there are some examples
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Native_messaging#App_side

from ff2mpv.

I've added @b4zz4's manifest and some information on manifest locations on Windows to the wiki.

from ff2mpv.

For future reference: #24 added Windows support.

from ff2mpv.

@woodruffw Is this correct?

I installed git. Python3, youtube-dl and mpv were already installed and in system path variables.
But the final command gives me this error:

from ff2mpv.

@Asinin3 It looks like you're trying to run check-config-win.py in the wrong directory: you're in mpv's directory, not the ff2mpv clone. You should run it from there.

from ff2mpv.

Now I get this.

Checking: HKEY_CURRENT_USER Software\Mozilla\NativeMessagingHosts\ff2mpv
Path from registry key is: %USERPROFILE%\ff2mpv\ff2mpv-windows.json
Traceback (most recent call last):
  File "check-config-win.py", line 39, in <module>
    raise ValueError("JSON file does not exist:", json_path)
ValueError: ('JSON file does not exist:', '%USERPROFILE%\\ff2mpv\\ff2mpv-windows.json')

from ff2mpv.

Sorry, I don't know too much else about how that script works (I'm not a Windows user and it was contributed by another ff2mpv user).

@thomastay Any thoughts here? (Sorry for the ping.)

from ff2mpv.

no problem @woodruffw , happy to help.

@Asinin3 %USERPROFILE% is a batch variable, it won't work in a python script. Try making the registry key an absolute path, without the %USERPROFILE% stuff.

from ff2mpv.

So, it looks like everything is configured properly. The json file, bat file, py file etc are all there. But clicking on the add-on button in Firefox does nothing. Opening the bat file manually does nothing, as does opening the .py file.

2021 edit: fixed. Seems like new update to this repo fixed it.

from ff2mpv.