Setting WOODPECKER_DATABASE_DATASOURCE_FILE does not work as expected when using docker image about woodpecker HOT 12 CLOSED

Yes, it is causes upstream, but I do not know if it can be called an issue.

If we change the Dockerfileto something like this:

RUN echo "/var/lib/woodpecker/woodpecker.sqlite" > /etc/woodpecker-datasource.conf
ENV WOODPECKER_DATABASE_DATASOURCE_FILE=/etc/woodpecker-datasource.conf

the problem should vanish.

If the user does set -e WOODPECKER_DATABASE_DATASOURCE... this will take precedence and if he sets -e WOODPECKER_DATABASE_DATASOURCE_FILE...it will overwrite the setting in the Dockerfile.

from woodpecker.

But we get this flag from Env via os package:

Yes, I know, I mean we're using the FilePath feature of urfave/cli.

Note that default values set from file (e.g. FilePath) take precedence over default values set from the environment (e.g. EnvVar).

Weird, then this should work 🤔 Or do I misunderstand something completely here?

from woodpecker.

Yeah, we need more gold tests :) There are no open issues about precedence. So, should work...

from woodpecker.

Precedence rules are different https://cli.urfave.org/v2/examples/flags/#precedence

Envelope var before file.

from woodpecker.

In my oppinion, the env var should take precedence to the content of some file.

The shorter the lifetime of a flag the higher the precedence. Rational: The user wants to override some argument for the next execution of a program without much hazzle.

So

1. command line arg
2. Env var
3. Some file

Shall I post a PR for changing the Dockerfile?

from woodpecker.

Only database settings don't work, right? Do other (WOODPECKER_GRPC_SECRET_FILE, WOODPECKER_AGENT_SECRET_FILE, WOODPECKER_GITEA_CLIENT_FILE, WOODPECKER_GITEA_SECRET_FILE) settings work as intended?

the env var WOODPECKER_DATABASE_DATASOURCE is set in the Dockerfile and takes precedence

There

from woodpecker.

Yes, it is only the datasource, others work as expected.

I do not have an idea of what could be changed. The code uses a sqlite file relative to the executable, but this can not be used with docker, as yoiu can not mount a volume there.

from woodpecker.

I think we should process WOODPECKER_DATABASE_DATASOURCE_FILE with higher priority than WOODPECKER_DATABASE_DATASOURCE as it is supposed to be more secure. So, that is is not a documentation issue.

from woodpecker.

It looks like this is an upstream issue of https://github.com/urfave/cli because we're directly using the feature:

from woodpecker.

It looks like this is an upstream issue of https://github.com/urfave/cli because we're directly using the feature

But we get this flag from Env via os package:

- FilePath: os.Getenv("WOODPECKER_DATABASE_DATASOURCE_FILE"),
+ FilePath: "/etc/mysql/password",

Note that default values set from file (e.g. FilePath) take precedence over default values set from the environment (e.g. EnvVar).

Also If EnvVars contains more than one string, the first environment variable that resolves is used.

Precedence.

from woodpecker.

Shall I post a PR for changing the Dockerfile?

Would be fine for me.

from woodpecker.

ah now i know where it did come from :D

please dont fix bugs in the wrong place ... this bugfix would e.g. not fix it for anything not using docker

(...yes it might not be a problem as that environments dont have preset things... but it still will exist)

from woodpecker.