Comments (2)
kevinleung23
commented on July 18, 2024
@howlowck I like this suggestion a lot. The decision to be consistent was actually made with DX in mind (in an attempt to be helpful). This is good actual DX feedback and I agree the parameters should be ordered based on developer frequency of utilization.
Marking potential and will revisit in an upcoming sprint. However, feel free to mark accepted and get this in the backlog. Since this concerns API, this should be done sooner rather than later. 👍
from wolf-core.
kevinleung23
commented on July 18, 2024
Potentially a new feature but tagging it here because of relevancy.. noticed Slot.validate is the only property to not have access to the storage layer object.. Do we want to add this as a second parameter so all slot properties are consistent?
Use case: A user would like to validate the submittedValue based on values within the state.
from wolf-core.
Related Issues (20)
- [Epic] Allow multiple abilities on single turn HOT 1
- Change the Wolf Runner interface to allow multiple user `messageData` HOT 2
- Invoke wolf stages per multiple `nlpResult` in WolfRunner
- [EPIC] Update v3 Documentation
- Pass the Storage Layer object to the `onComplete` and `onFill` function
- provide the messageData in the onComplete function HOT 1
- Remove peer-dependencies
- Update onFill parameter order
- Ensure consistent use of `submittedData`/`submittedValue`
- Update Wolf-Botbuilder Readme
- Consistent order of Slot and Ability Parameters, with convoStorageLayer 2nd
- Implement slot history to allow for `getValue` parameter for slots. HOT 3
- Update wolf-core examples to use 3.0 Alpha functionality
- Improve Tests
- Build issue with TypeScript project "botbuilder does not export member 'Promiseable'" HOT 4
- [alpha] Not filling multiple slots in a single turn HOT 1
- Acceptance Tests HOT 1
- [Investigate] Traces `getValue` generic type error
- Wolf ignores the entities if the incoming intent matches the target intent
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wolf-core.