Cannot build `pxtone` due to invalid character when system codepage is 936 about sdl-mixer-x HOT 6 CLOSED

Thanks, I can confirm it can pass the build without any modifications.

from sdl-mixer-x.

Huh, good catch. I'll fix that. Anyway, origian charset of these files was Shift-JIS, and I was sure that I converted all of them into UTF-8, I'll fix this as fast as possible.

from sdl-mixer-x.

Anyway, what MSVC version you do have? On my end, it builds with many different versions of MSVC normally 🤔

from sdl-mixer-x.

I guess, the fix would be an adding of the kind of /utf8 flag to the compiler (at CMake setup) to eliminate this issue. I'll try some on my end, and I'll let you know when I'll implement this.

from sdl-mixer-x.

Thanks for the quick reply!

I was sure that I converted all of them into UTF-8

Yes, I can confirm this, but msvc still not build it until I resave both file to UTF-8 BOM, which is the default format when save as unicode in visual studio.

what MSVC version you do have?

2022 community, latest update, 17.5.X IIRC.

On my end, it builds with many different versions of MSVC normally

Then it must by the language difference: some character has no issue in your language but will affect the build on my side.

I guess, the fix would be an adding of the kind of /utf8 flag to the compiler

I'm not familiar with cmake, if this flag can force compiler to work in unicode mode instead of auto detect file encoding format, then it should work.

from sdl-mixer-x.

Recently I sent a fix to CMake build, so it adds /utf-8 argument and it should work just fine. Please verify the thing. Project needs to be re-generated after CMake side update.

from sdl-mixer-x.