Code Monkey home page Code Monkey logo

Comments (3)

wjakob avatar wjakob commented on June 2, 2024

It's easy to fix this, but it will come with a cost. Keyword argument dispatch will become slower for everyone. I am not sure if the cost outweighs the benefits.

from nanobind.

tjstum avatar tjstum commented on June 2, 2024

This would probably make the code pretty unwieldy, but could keyword argument dispatch first try the address-based check, and then, before giving up on the overload (or, I guess after trying all overloads but before giving up completely), try the slower, equality-based approach?

If that's too much, do you have any other suggested workaround?

from nanobind.

oremanj avatar oremanj commented on June 2, 2024

CPython itself (initialize_locals in ceval.c) does the id comparison first, and falls back to contents comparison if there's no match for a given kwarg. That would limit the penalty to functions that take var-keywords and also have some named keywords that aren't provided, which I'm guessing would be more palatable? I can work on a patch.

from nanobind.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.