jQuery-like find mistook for native find about eslint-plugin-lodash HOT 10 CLOSED

I cannot think of how to fix this at the AST level.

from eslint-plugin-lodash.

Neither can we. At the AST level, there's no way of knowing that $(movieElement).parents('h3').siblings('.show_results') isn't an array, and this plugin should be library agnostic, except for Lodash itself.
I guess I would advise to turn off this rule for corresponding lines, files, or folders in general.

from eslint-plugin-lodash.

Technically, you could add a check if the top-most node in the chain is $() declaration.

99% of the code that relies on jQuery like DOM iterators use this convention.

from eslint-plugin-lodash.

It gets a bit harder if you do something like this:

$(movieElement)
    .parents('h3')
    .siblings('.show_results')
    .find('.film_time_listing span a')
    [0]
    .find(conditionFn)

Though thats an edge use-case.

from eslint-plugin-lodash.

Yes, technically we could. However, Like I said, the plugin doesn't assume anything about variables by their names except for Lodash. There could technically be a $() definition in which the find is the native ES6 Array.prototype.find.
In general, we have no way of knowing that any method that's named like an array method isn't used on an array.
Again, in this case I think you should disable this specific rule.

from eslint-plugin-lodash.

There is no way to disable it just for "find" and otherwise this is the only rule that I find useful.

On Nov 25, 2015, at 16:38, Omer Ganim [email protected] wrote:

Yes, technically we could. However, Like I said, the plugin doesn't assume anything about variables by their names except for Lodash. There could technically be a $() definition in which the find is the native ES6 Array.prototype.find.
In general, we have no way of knowing that any method that's named like an array method isn't used on an array.
Again, in this case I think you should disable this specific rule.

—
Reply to this email directly or view it on GitHub.

from eslint-plugin-lodash.

This also breaks when using http://bluebirdjs.com/docs/api-reference.html. There is no obvious solution. Shame, in theory it is a nice linting rule. In practise it is just not functional.

from eslint-plugin-lodash.

I wonder how feasible would it be to define something like this in a run-time setup.

from eslint-plugin-lodash.

👍 +1 for adding configuration to this rule so that we can disable it just for find.

from eslint-plugin-lodash.

For the record, I never suggested to disable this rule just for find and I think thats a bad idea.

from eslint-plugin-lodash.