hasOnlyOneStatement is throwing TypeError: Cannot read property 'type' of undefined about eslint-plugin-lodash HOT 7 CLOSED

While it is related source line, this function should not have been called
in the first place (since the expected parameter type is function entity).

On Thu, Feb 4, 2016 at 2:36 PM, Mikołaj D. [email protected] wrote:

Related source line:
https://github.com/wix/eslint-plugin-lodash/blob/master/lib/util/astUtil.js#L114

—
Reply to this email directly or view it on GitHub
#23 (comment)
.

from eslint-plugin-lodash.

Yes, you're right, I realized this a minute later and deleted my comment ;)

from eslint-plugin-lodash.

Fixed in 1.0.4.

from eslint-plugin-lodash.

Now it is failing with:

/Users/gajus/Documents/dev/canonical-code-style/canonical/node_modules/eslint-plugin-lodash/lib/util/astUtil.js:114
    return func.type === 'ArrowFunctionExpression' ? !_.get(func, 'body.body') : _.get(func, 'body.body.length') === 1;

/**
 * Returns whether the node specified has only one statement
 * @param {Object} func
 * @returns {boolean}
 */
function hasOnlyOneStatement(func) {
    return func.type === 'ArrowFunctionExpression' ? !_.get(func, 'body.body') : _.get(func, 'body.body.length') === 1;
}

from eslint-plugin-lodash.

@ganimomer Can you make me a contributor? I am only interested in patching bugs such as this.

from eslint-plugin-lodash.

Hi,
I fixed the error again. I ran your code sample against all the rules and that's the only place that exploded. (It's also the only other place to call hasOnlyOneStatement).

As for your request, you can always submit a PR and we try to get to it ASAP.
We get notified of any new issues and PRs anyway, but it helps to mention @idok, @danyshaanan or me.

from eslint-plugin-lodash.

Thank you

On Feb 7, 2016, at 10:12, Omer Ganim [email protected] wrote:

Hi,
I fixed the error again. I ran your code sample against all the rules and that's the only place that exploded. (It's also the only other place to call hasOnlyOneStatement).

As for your request, you can always submit a PR and we try to get to it ASAP.
We get notified of any new issues and PRs anyway, but it helps to mention @idok, @danyshaanan or me.

—
Reply to this email directly or view it on GitHub.

from eslint-plugin-lodash.