Comments (8)
Princesseuh
commented on September 26, 2024
This extension does not run inside Svelte files. Is it the code inside the Svelte files that get messed up?
from language-tools.
danielo515
commented on September 26, 2024
Yes, it also breaks autocompletion in svelte files. The extension may not
directly deal with svelte files, but if I disable it then the problem goes
away
…On Sun, 12 May 2024 at 08:02, Erika ***@***.***> wrote:
This extension does not run inside Svelte files. Is it the code inside the
Svelte files that get messed up?
—
Reply to this email directly, view it on GitHub
<#869 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARKJWO3WFK3W63AN37GJVDZB4AXXAVCNFSM6AAAAABHSOJ5T6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGEZTCNZRGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from language-tools.
Princesseuh
commented on September 26, 2024
Does it break auto completions or does it break what you described in the first post?
from language-tools.
danielo515
commented on September 26, 2024
It breaks automatic imports and refactors. Suggestions do work (but very
bad)
…On Sun, 12 May 2024 at 19:05, Erika ***@***.***> wrote:
Does it break auto completions or does it break what you described in the
first post?
—
Reply to this email directly, view it on GitHub
<#869 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARKJWNPTWTC4NFLAJSQ3Q3ZB6OOXAVCNFSM6AAAAABHSOJ5T6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGMYTMMJZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from language-tools.
Princesseuh
commented on September 26, 2024
It seems to be some sort of conflict between the Svelte TypeScript plugin and the Astro one. It seems like both plugins are trying to do the refactor at the same time and so it ends up generating broken code. For what it's worth, you can actually undo the changes if you undo the move, and not the latest change. The LSPs are doing it correctly, as far as I can tell, just the TypeScript plugins.
I cannot reproduce a difference regarding auto imports / completions with or without the Astro plugin, so not sure on that one. Since auto imports in the respective files would be handled by the LSPs, I'm not sure how the Astro extension could affect the Svelte one in that regard.
from language-tools.
Princesseuh
commented on September 26, 2024
This should be fixed in 2.9.1. Apologies for the inconvenience. If you have the time and would like to, I would appreciate if you updated your review on the VS Code marketplace to reflect this.
from language-tools.
danielo515
commented on September 26, 2024
That is awesome! Thank you very much. I will update it, sorry about it. I wrote it in a moment where I was very frustrated
from language-tools.
Princesseuh
commented on September 26, 2024
No worries, it happens! We're all humans here
from language-tools.
Related Issues (20)
- Extension causes the JS/TS language server to crash HOT 1
- 🐛 BUG: autocomplete does not work with inline style when Japanese text is included in an element. HOT 1
- 🐛 BUG: 2.8.6 breaks typescript server on VSCode
- 💡 RFC: Add code fix to replace quotes with curly braces
- 🐛 BUG: astro check cannot parse file HOT 3
- 🐛 BUG: Go to problems after version 2.9.0 HOT 7
- 🐛 BUG: Astro check support for Object.groupBy() HOT 4
- 🐛 BUG: TS Tries To Parse Code In `<pre>` Tags HOT 1
- 🐛 BUG: Installation of `@astrojs/react` leads to failure of `astro check` HOT 1
- 🐛 BUG:Error reported for attribute vscode HOT 1
- 🐛 BUG: Error detected while processing BufReadPost Autocommands for "*" HOT 2
- 🐛 BUG: Rename symbol doesn't work inside `<script>` tags, HOT 4
- Update import on `<script src=>` when file is moved
- 🐛 BUG: Widespread Intellisense Issues in Astro Projects in VS Code 1.91.0 HOT 8
- 🐛 BUG: v2.11.0 is crashing with Sublime Text LSP 2.2.0 HOT 3
- 🐛 BUG: Refactoring `astro.config.mjs` file name is wrong HOT 1
- 🐛 BUG: Syntax highlighting is broken HOT 3
- Astro fails to detect `is:inline` in newly generated project HOT 8
- Variable values not visible on hover HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from language-tools.