Comments (4)
erino
commented on September 13, 2024
I was thinking that we should remove the google_analytics_tracking_code method, it's not that hard to copy the code from Google. The add_tracking_code method is the timesaving part.
from slices.
thomasmarshall
commented on September 13, 2024
Yep, I agree with that.
from slices.
bensymonds
commented on September 13, 2024
Can we just close this issue, given we have #101? I never really know what the best thing to do is when there's a PR covering an issue. It seems like the issue is now tracked by the PR, so we don't need the issue any more.
from slices.
erino
commented on September 13, 2024
This is now covered in #101
from slices.
Related Issues (20)
- Handle permalink being an empty string in path_from_attributes
- [RFC] Slice Linting HOT 5
- [RFC] Fragment caching HOT 1
- [RFC] Allow users to opt-out of Entry templates
- Cannot POST to /
- Page preview for the homepage
- Better messaging around auth
- NotImplementedError in Admin::SiteMapsController#index HOT 5
- Improve recording of exceptions
- `Slices::Config.google_apps_domain` should be removed HOT 1
- Don't redirect to sitemap on Mongoid::Errors::DocumentNotFound HOT 1
- Not really an issue... HOT 6
- Images only rendering at admin size, not original HOT 2
- Can't currently host Slices for free on Heroku HOT 1
- Link to next and previous page from current page HOT 2
- [RFC] Replace wiki with in-repo guides HOT 4
- `Admin#super_user?` is not checked server-side
- Search terms need escaping before passing into regexps
- Show time zone in date picker
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slices.