Code Monkey home page Code Monkey logo

Comments (5)

Prinzhorn avatar Prinzhorn commented on June 10, 2024 3

However, I am uncertain about the stability of this project, given the short notice deprecation, complete lack of documentation, etc.
As you can see, that library is no longer maintained. If I base my app on it, I need to have confidence that the lib and feature is going to be there in the future.

Instead you'd put the burden of maintaining it on better-sqlite3?

But many dev like me absolutely need it.

Then maintain it?

I don't mean to sound rude, but better-sqlite3 has essentially been in maintenance mode for quite some time. I don't remember the last real bug report and most activity is around support for newer Node.js/Electron versions.

This is not about "dev like me absolutely need it" or "discoverability" or "this is a no-go" it's simply that there is no capacity here to implement and support this feature. And since it can easily be implemented in user-land (and better-sqlite3 was always meant as a very low level wrapper anyway) then I recommend doing that.

We'd rather have low level things like N-API or being able to cooperatively kill a worker mid transaction then a feature that can be implemented outside of better-sqlite3. Because these are at the core of it.

from better-sqlite3.

leafac avatar leafac commented on June 10, 2024 2

The library that adds tagged template support to better-sqlite3 is here: https://github.com/radically-straightforward/radically-straightforward/tree/main/sqlite

It used be called @leafac/sqlite and now it’s called @radically-straightforward/sqlite because it’s becoming part of a set of tools that I’m developing called Radically Straightforward. I’m still working on some parts of Radically Straightforward, but the SQLite part is ready for use and documented.

I hope you have a good time using it.

from better-sqlite3.

mceachen avatar mceachen commented on June 10, 2024 1

I'm -1.

@JoshuaWise has done a great job in keeping this library focused and simple, and yet there are still a ton of unresolved issues on this project.

This would be a nice feature, but string templating, by design, doesn't have the same SQL-aware expressiveness, composability, and vendor-specific syntax translation as something like knex. In other words, not all users of this library will want to (or need to) switch to this new API.

If this feature could not be added as an additional layer, but had to be incorporated in this library, I might change my mind, but IMHO, what @leafac has done with a layer on top of this library is the correct way to do it. Whether that code is maintained or documented sufficiently is a wholly different matter.

from better-sqlite3.

benbucksch avatar benbucksch commented on June 10, 2024

not all users of this library will want to (or need to) switch to this new API.

That's fine. You're not required to use it.

But many dev like me absolutely need it. A library that doesn't offer this is a no-go from the get-go for me. Just because you don't need it, or it could theoretically be done elsewhere, is not a good reason to reject the feature. For me, this is an essential, fundamental feature of any SQL API.

what @leafac has done with a layer on top of this library is the correct way to do it.

As you can see, that library is no longer maintained. If I base my app on it, I need to have confidence that the lib and feature is going to be there in the future.

Also, there's the issue of discoverability. If I find better-sqlite3, I won't know that there is a better way than the "better sqlite3" (forgive the pun, but that's my point).

from better-sqlite3.

benbucksch avatar benbucksch commented on June 10, 2024

there is no capacity here to implement and support this feature

That's fair enough. Thanks for letting me know.

from better-sqlite3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.