Code Monkey home page Code Monkey logo

Comments (6)

ikmak avatar ikmak commented on September 22, 2024

@willscott
I've tried to mount with options locallocks, and it looks better.
But there are still some problems.
Word docx(doc) files could be saved with some wired temporary directories like abc.docx.sb-xxxxxx-xxxxx
Excel xlsx(xls) files could be saved without any sb temporary directory
PowerPoint pptx(ppt) files could be created but couldn't be saved.

  • NFS Server: macOS, sudo ./example/osnfs /path/to/files/ 45678
  • NFS Client: macOS, sudo mount_nfs -vvv -o port=45678,mountport=45678,proto=tcp,nosuid,sync,locallocks "localhost:/nfs" /path/to/mount

from go-nfs.

willscott avatar willscott commented on September 22, 2024

I wonder if #72 was the underlying issue behind this

can you try again with the current version?

from go-nfs.

ikmak avatar ikmak commented on September 22, 2024

@willscott
Same...
image

from go-nfs.

ncw avatar ncw commented on September 22, 2024

Does anyone have a clear idea what is happening here? This is affecting rclone users in rclone/rclone#7973 in exactly the same way.

Putting nolock or locallocks doesn't fix the problem though - the symptoms are as described above #54 (comment)

Is this a problem because the nfs server doesn't implement locking? If so could we implement a skeleton locking system?

I notice that memfs has a stubbed out Lock and Unlock which don't appear to be called anywhere

// Lock is a no-op in memfs.
func (f *file) Lock() error {
return nil
}
// Unlock is a no-op in memfs.
func (f *file) Unlock() error {
return nil
}

from go-nfs.

willscott avatar willscott commented on September 22, 2024

@ncw - the reason memfs does not implement lock / unlock is because the accompanying 'Network Lock Manager (NLM)
protocol' is not implemented here. The protocol is documented in RFC 1813 - but it will be a bigger effort than the method you point to.

from go-nfs.

ncw avatar ncw commented on September 22, 2024

Thanks @willscott

What do you think the best way forward with this issue is? Rclone can't support locking so how can we tell the clients not to try?

from go-nfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.