Bug in readdirplus causing all files in a directory to be the same about go-nfs HOT 2 CLOSED

Does it make more sense for the onreaddirplus method to make a fully copy of the slice each time it calls ToHandle, or to set the expectation to the user handle that the slice it's been given isn't guaranteed to remain constant after the call to ToHandle?

It seems the easy fix is to keep the semantics in onreaddirplus the same, and change helpers/cachinghandler to have it's entry be of strings.Join(p, "/") and do the copy there.

from go-nfs.

That would work, but dealing with slice is still tricky. Also on the FromHandle you will need to split back into slice. IMHO, having a joinPath(parent []string, element ...string) []string convenience function and replace all the append(p, ...) in the code might be best for the sake of avoiding similar bugs.

func joinPath(parent []string, elements ...string) []string {
	joinedPath := make([]string, 0, len(parent))
	joinedPath = append(joinedPath, parent...)
	joinedPath = append(joinedPath, elements...)
	return joinedPath
}

from go-nfs.