GEN2 X1 Missing Sensors / Readings about homeassistant-solax-modbus HOT 13 CLOSED

Confirmed if I change my Integration to Gen2x1 "Today's Yield" drops to 0kWh

This is on 0.5.0b3

from homeassistant-solax-modbus.

Some Additional that seem to have taken a bit of a holiday but work when using Gen3 integration

I know some may be reading the wrong register hence they are getting a reading but here they are

Grid Import
Measured Power
Today's Yield (As above)
Total Yield

from homeassistant-solax-modbus.

I am trying to find the cause of the problem ... This is probably a side effect of the code restructuring but I have not found the error yet ...

from homeassistant-solax-modbus.

I have only looked into Today's Yield so far (today_yield) but I can't see anything obvious.

It's declared as allowedtypes=ALLDEFAULT, which matches all the other generic sensors between Generation's.
If that one didn't work you would expect most of the other sensors not to work either?

I'll look into the others tomorrow.

from homeassistant-solax-modbus.

Yes, the sensor declarations look ok, but I fear the init.py sequential reading of parameters might get out of sync for gen2.

from homeassistant-solax-modbus.

Found the error, but as I do not have a Gen2 description I do not know how to correct:
the error was not introduced by the doce resturcturing, but by a prior change.
In read_input_registers0, there is an if statement searching for a GEN2 condition

The If clause consumes 4 variables, the ELSE clause consumes 6 variables.
I knot know where I should add a skip_bytes(4) statement

from homeassistant-solax-modbus.

That will be from when I added in input_energy_charge & output_energy_charge for the Gen2 as they sit in a different pattern of registers on the Gen2 vs Gen3 & Gen4

I'll double check the docs, maybe 2 registers got deleted by accident at some point? or the skip_bytes(4) did?

from homeassistant-solax-modbus.

Within __init__.py lines 768 to 772 shouldn't be inside the else: statement.

@matthewjporter can you change the following:

to:

Could you please confirm if it works correctly and then I can push a new update out? Or would you prefer me to just push it out anyway? Then you can just update through HACS.

I have switched to Gen2 mode and I now have Today's Yield showing.

from homeassistant-solax-modbus.

OK, thanks, I will test in my development fork also ...

from homeassistant-solax-modbus.

Looks indeed OK this proposal to fix

from homeassistant-solax-modbus.

@matthewjporter

I have pushed it out as 0.5.0b4 as I am pretty confident this fixes that issue.

from homeassistant-solax-modbus.

Just updated (via phone) and on the surface looks to be resolved as I am seeing states

Will check later when at my PC

Thanks Guys

from homeassistant-solax-modbus.

I am closing this issue down as the problem is fixed now.

from homeassistant-solax-modbus.