Comments (8)
Many thanks for this @fruzsinaagocs . I think I have seen similar behaviour on other machines that I work on. It is likely due to differences in vim version 8.0 and 8.1 (I have 8.1 on my machine). Ideally it should work for both.
First (and this may be wrong), I don't think vim script supports default values of arguments like bufname = ''. I changed this to just bufname in the relevant line, which seemed to have made the first error disappear.
I don't think connect
is ever used without an argument, so I believe this change should fix the issue. @GoldsteinE should weigh in on this if I'm wrong though. Does :Iterm
work if you've made this change?
term_kill wasn't actually used in its enclosing function, so I just deleted the line it appeared in.
This may also be a difference between 8.1 and 8.0. If there's no change in functionality then I don't see any problem with removing it, although it may be related to @GoldsteinE 's change that makes sure the terminal shuts down gracefully.
Please submit a pull request and I'll try it out on my machine to see if everything is behaving as it should.
from vimteractive.
I'll submit a PR shortly!
from vimteractive.
Ah, actually in using it on another machine, I've noticed that the default argument was doing something important. Are you able to create a similar branch between vim versions which puts in a default argument for bufname for vim > 8.1 ?
from vimteractive.
I did something different that hopefully works across versions, see the fresh PR.
from vimteractive.
What was the important thing that the default argument did?
from vimteractive.
It meant that if only one terminal is open, if you ran :Iconn
without any arguments then it would automatically connect to the only available terminal.
from vimteractive.
@fruzsinaagocs Has this issue been resolved by #13 and #12 ?
from vimteractive.
Yes, this issue can be closed now.
from vimteractive.
Related Issues (20)
- backspace (in insert mode) frozen after having sent lines to interactive program HOT 1
- Buffer name choice causing error. HOT 2
- Filetype recognition shell
- Support for multiple terminals at once HOT 21
- Send results back HOT 3
- Send selected text to Ipython console HOT 1
- neovim compatible? HOT 4
- Three issues with respect to user-friendly HOT 3
- Vertical split HOT 3
- The plugin can't recognize existed console HOT 1
- No new line on windows HOT 3
- Can't backspace up to previous line in Insert mode HOT 3
- Can't use ctrl-s in visual mode HOT 2
- +terminal HOT 1
- Prevent automatic scroll on switching splits HOT 3
- feature request: wolfram support HOT 3
- Sending cell of code HOT 2
- Interactive plotting broken
- run vimscript commands interactively
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vimteractive.