Low contrast Git warning about plastic HOT 6 CLOSED

Hi @bearinsun, I tend to cycle around my projects, moving on when I get bored. I'll be back to Plastic soon 🙂

from plastic.

Released in v2.2.0

from plastic.

That's not good. Thanks for spotting this. It seems like Dark+'s approach to this is to use the light yellow for borders but a darker one for backgrounds:

As the foreground (the text) can't currently be styled for that box. Ok, I'll look into it. I want to make the config builder as simple as possible too and would rather not have to add an option for warning_dark or whatever. I'll have a play, maybe adding some trasparency to that background will work (it depends if there's a colour underneath it), or I could use the tinycolor2 package (that I'm using to check colours validate) to darken the chosen colour for warnings and errors for backgrounds. Either way, the fix should be easy enough. This may sound like waffle to you but I like to write down my thoughts here so I can check back when I come to do the work.

Cheers.

from plastic.

@will-stone just checking in—do you have any status updates? Can I help with anything?

from plastic.

Ok, I've taken a look at this and it looks like the only way to currently solve the problem is to make the warning and error background colours darker. However, there are some new options coming soon that will allow me to set the text colour: microsoft/vscode#57734

I'd rather wait for that to go in (which looks like it will be the next release). Mainly because it allows me to keep the flat look I intended for.

from plastic.

Sounds good—glad to hear there's a plan. Thanks for keeping Plastic updated!

from plastic.