invalid html output when sidebox content empty about advanced-sidebox HOT 9 CLOSED

This certainly needs to be addressed. Using the current system the main plugin file calls methods of the Sidebox_addon object $modules and doesn't have access to whether or not the module had content or is just an empty box.

So any change here would need to be made in the individual modules themselves. Perhaps add one setting as you have suggested and then have each module contain a default 'nothing to display' message tailored to the specific module and also check to see if it should display anything at all.

It would be relatively simple to do but require a bit of time. I am off tomorrow so I will try to dig in and get some of this going.

Do you really think the setting is necessary? I kind of think we should really just make a decision and go with it and then if people complain then address it then. No need adding more work for something that turns out to be a non-issue.

just my thoughts

from advanced-sidebox.

Do you really think the setting is necessary?

I agree with you all the way.
Whats important here is only fact that 'at least something like
should be within tbody tags' regardless from if there are any content or not - to maintain valid html structure.
and thats it.

The rest was just my common way of thinking forward, far beyound the current problem,
which always help me to avoid dead ends later, where its more easy to scrap something and remake from beginning,
than add new features, because of not flexible design which didnt predicted such things much earlier.

But more i think about it, more choices, possibilities, and things i see out there,
like displaing boxes depending on group permissions ect, which could blend nicely with this
and many other possible things (why display login box to logedin user? should display admin only box to everyone?)

While these ideas are still in shadows and need for them is not even fully grasped,
its really better to concentrate on 'tbody' issue and leave topic about 'what, why and from who to hide or not'
until it mature enough, or we will end up later with 100 separate show / hide options
all having the same functionality but different name.

from advanced-sidebox.

I think we are in agreement then.

I will work on ensuring the HTML produced is valid and keep in mind that I may have to edit that code later to include a setting check and so keep it flexible.

Will update when I make progress.

from advanced-sidebox.

Okay I think I have got this solved. Let me know if I missed anything.

Cheers.

from advanced-sidebox.

I saw there something not rite in html (which i will continue to test),
but for a moment while testing private messages box, fiew things within it caught my attention
and it end up in improvements in this module.

I think i just finished with private messages module for now,
and will post it as update to not forget, then im back to continue testing html and stuff.
(in fiew minutes there should be new report about private messages box update)

from advanced-sidebox.

Okay just let me know if this issue is fixed or not whenever you have time. I will look myself again, but I think you have a better eye for HTML than I do.

Cheers

from advanced-sidebox.

Ok, pm's block has been fixed in other report.
Im goin back now to checking html which i mentioned in previous comment.

from advanced-sidebox.

Cool. Let me know if you find anything else.

from advanced-sidebox.

fixed at #11

from advanced-sidebox.