Division by zero warning, might be a fluke about pixiewps HOT 10 CLOSED

Before adding the tag I compiled the program with Clang on Mac OS X so I thought everything was fine...

The problem here is that under FreeBSD, CLOCKS_PER_SEC = 128, leading to a division by zero.

Source: http://bugs.vcmi.eu/view.php?id=719

from pixiewps.

Can you fix it and push another release tag? I'd update the port then to have this fixed as well.

from pixiewps.

I will look later today. I'm not at my compiling station right now.

Thank you for testing and happy new year to you too :)

from pixiewps.

@fbettag
It should be fixed now. I used gettimeofday() from sys/time.h instead of clock() from time.h.

Tested again on Ubuntu 32 bit (GCC), Mac OS X 64 bit (Clang) and Windows 64 bit (with MinGW). No errors or warnings (using -Wall -Wextra).

from pixiewps.

seems fixed now :) can we get another release? :)

from pixiewps.

Well the only thing that stands out:
cc -std=c99 -O3 -Wall -Wextra -DDEBUG -o pixiewps pixiewps.c random_r.c crypto/sha256.c crypto/md.c crypto/md_wrap.c
In file included from pixiewps.c:32:
./pixiewps.h:220:13: warning: comparison of integers of different signs: 'char' and 'unsigned int' [-Wsign-compare]
if (*list <= (max_digit + '0')) {
~~~~~ ^ ~~~~~~~~~~~~~~~
1 warning generated.

from pixiewps.

Mind testing again? Possibly with -Wall and -Wextra. If everything's good I'll push another tag.

from pixiewps.

cc -std=c99 -O3 -Wall -Wextra -DDEBUG -o pixiewps pixiewps.c random_r.c crypto/sha256.c crypto/md.c crypto/md_wrap.c
:)

looks good now

from pixiewps.

Pushed new tag 1.2.2.

Thank you again, much appreciated.

from pixiewps.

Submitted to FreeBSD https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205870 :)

No worries, thanks for doing the code, i just package :)

from pixiewps.