Comments (11)
wichtounet
commented on June 19, 2024
Hi
FYI, the Mac OS building code is highly experimental, I have never tested it and it was contributed by @robromano
Looking at the errors, I can see two things:
- It looks like the loguru submodule is missing. Can you do a
git submodule update --init --recursive? - It looks like there are C++17 warnings and issues, can you try replace this line in Cmakelists.txt
set(CMAKE_CXX_STANDARD 14)
by
set(CMAKE_CXX_STANDARD 17)
from budgetwarrior.
ljubomirsinadinovski
commented on June 19, 2024
I changed the CMAKE_CXX_STANDARD, but i still have problems with installing loguru. I have also tried this solution:
git submodule update --init --recursive
Then, try the pull --recurse-submodules=true again.
Somehow, [activating the traces](https://stackoverflow.com/a/56094711/6309) improve the situation:
git -c trace2.eventTarget=1 pull --recurse-submodules=true
Source: https://stackoverflow.com/questions/64190258/git-submodule-fails-with-could-not-access-submodule
from budgetwarrior.
ljubomirsinadinovski
commented on June 19, 2024
I also tried doing change in the .gitmodules file by replacing the https into the ssh path of the project:
[submodule "loguru"]
path = loguru
url = [email protected]:emilk/loguru.git
Still not working..
Then I tried:
git submodules deinit loguru
git submodule update loguru
git submodule init loguru
git submodule sync loguru
git submodule set-url loguru [email protected]:emilk/loguru.git
git git submodule update --init --force -
from budgetwarrior.
robromano
commented on June 19, 2024
I have not been maintaining the CMakeLists.txt for this project.
When a new package is added, we need to update CMakeLists.txt accordingly.
For loguru and possibly others, for example, add the requisite
include_directories() statement. Some packages have native CMake support
so you can do find_packages() for those.
Try this diff:
$ git diff
diff --git a/CMakeLists.txt b/CMakeLists.txt
index c6cb4c2..68af89b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -12,6 +12,7 @@ find_package(OpenSSL REQUIRED)
include_directories(include)
include_directories(cpp-httplib)
+include_directories(loguru)
include_directories(${OPENSSL_INCLUDE_DIR})
add_subdirectory(src)
…On Fri, 29 Jul 2022 at 15:11, Ljubomir Sinadinovski < ***@***.***> wrote:
I also tried doing change in the .gitmodules file by replacing the https
into the ssh path of the project:
[submodule "loguru"]
path = loguru
url = ***@***.***:emilk/loguru.git
Still not working..
Then I tried:
git submodules deinit loguru
git submodule update loguru
git submodule init loguru
git submodule sync loguru
git submodule set-url loguru ***@***.***:emilk/loguru.git
git git submodule update --init --force -
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVDPZSZOWE6YSZ5ANPFFMTVWRJJPANCNFSM5427JTVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from budgetwarrior.
robromano
commented on June 19, 2024
The current error I see after setting C++ to 17 is
budgetwarrior/include/cpp_utils/string.hpp:18:72: error: no member named
'ptr_fun' in namespace 'std'
s.erase(s.begin(), std::find_if(s.begin(), s.end(),
std::not1(std::ptr_fun<int, int>(std::isspace))));
std::ptr_fun was a C++11 feature and fully removed from C++17.
…On Fri, 29 Jul 2022 at 15:56, Robert C. Romano ***@***.***> wrote:
I have not been maintaining the CMakeLists.txt for this project.
When a new package is added, we need to update CMakeLists.txt accordingly.
For loguru and possibly others, for example, add the requisite
include_directories() statement. Some packages have native CMake support
so you can do find_packages() for those.
Try this diff:
$ git diff
diff --git a/CMakeLists.txt b/CMakeLists.txt
index c6cb4c2..68af89b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -12,6 +12,7 @@ find_package(OpenSSL REQUIRED)
include_directories(include)
include_directories(cpp-httplib)
+include_directories(loguru)
include_directories(${OPENSSL_INCLUDE_DIR})
add_subdirectory(src)
On Fri, 29 Jul 2022 at 15:11, Ljubomir Sinadinovski <
***@***.***> wrote:
> I also tried doing change in the .gitmodules file by replacing the https
> into the ssh path of the project:
>
> [submodule "loguru"]
> path = loguru
> url = ***@***.***:emilk/loguru.git
>
> Still not working..
>
> Then I tried:
>
> git submodules deinit loguru
> git submodule update loguru
> git submodule init loguru
> git submodule sync loguru
> git submodule set-url loguru ***@***.***:emilk/loguru.git
> git git submodule update --init --force -
>
> —
> Reply to this email directly, view it on GitHub
> <#24 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAVDPZSZOWE6YSZ5ANPFFMTVWRJJPANCNFSM5427JTVQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
from budgetwarrior.
robromano
commented on June 19, 2024
#25 for fixing up all issues.
from budgetwarrior.
robromano
commented on June 19, 2024
wichtounet/cpp_utils#1 for cpp_utils fix needed.
from budgetwarrior.
wichtounet
commented on June 19, 2024
Thanks @robromano, we can discuss in your two PRs
from budgetwarrior.
robromano
commented on June 19, 2024
I just converted a repo of mine using Travis CI (which is now unsupported) to Github Actions - to automatically build and test all changes on push. Github Actions are fantastic.
I'd propose converting away from Makefile to CMake, and enable Github Actions workflow to build both platforms every push. I'll submit a PR.
Working example of CMake on Linux for budgetwarrior: https://github.com/robromano/budgetwarrior/runs/7660441303?check_suite_focus=true
(It probably used a newer version of GCC - which is why there are some new compiler errors there)
from budgetwarrior.
ljubomirsinadinovski
commented on June 19, 2024
@robromano how do i download the build? I don't see any artefact do download or anything, only logs
from budgetwarrior.
robromano
commented on June 19, 2024
You will still need to build it yourself, the GitHub action workflow is
just to verify future code submissions will build successfully with both
compilers/platforms.
…On Fri, Aug 5, 2022 at 2:33 AM Ljubomir Sinadinovski < ***@***.***> wrote:
@robromano <https://github.com/robromano> how do i download the build? I
don't see any artefact do download or anything, only logs
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVDPZUS5SGZVIZGLF3IVW3VXTNVJANCNFSM5427JTVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from budgetwarrior.
Related Issues (20)
- can't compile - HAS_MEM_FUNC missing HOT 4
- Compile error: src/pages/accounts_pages.cpp HOT 17
- Segmentation faults in some menu links HOT 2
- Understanding the design HOT 4
- Could not make install on Linux 20.04 LTS HOT 3
- XDG Base Directory compliance HOT 2
- Month overview does not work when no account is present HOT 1
- Can't build from source. HOT 4
- Unable to make HOT 2
- budget server command doesn't work HOT 5
- Clang support HOT 3
- Support for fractional shares HOT 1
- Extra double quote in bash completion file HOT 2
- Unable to load the configuration (/.local/share/budget) HOT 4
- Infinite error loop when adding a new asset HOT 7
- Error on make step HOT 2
- fatal error: 'openssl/ssl.h' file not found HOT 9
- Access denied on install to SIP protected directory HOT 1
- No such file or directory "bash_completion.d" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from budgetwarrior.