Code Monkey home page Code Monkey logo

Comments (5)

domfarolino avatar domfarolino commented on June 1, 2024 1

Ah, nice find! OK I'll close this, and I assume bikeshed will get fixed at some point in the meantime? Thanks for the quick investigation!

from observable.

domfarolino avatar domfarolino commented on June 1, 2024

OK so it turns out that "visitor callback controller" is actually used, so this is a non-issue. It just looks like it is not used because bikeshed won't highlight all of the references to it inside the algorithm. That's really weird. @tabatkins do you know why this might be? If you go to https://wicg.github.io/observable/#:~:text=and%20signal%20abort-,visitor%20callback%20controller,-with%20E. and click that variable, notice that the instance of that variable in step 2 of that whole algorithm/div does not highlight...

from observable.

tabatkins avatar tabatkins commented on June 1, 2024

The immediate cause is that the final instance of the term is broken across the line in the source, so Bikeshed isn't recognizing it as the same term as the other two instances. But that's probably broken behavior; I should be normalizing whitespace. I wonder if that's a regression from my changes a few months ago?

from observable.

domfarolino avatar domfarolino commented on June 1, 2024

Oh interesting. Yeah I guess I'd expect that to still work? At least a lot of WHATWG standards are happy to break in the middle of variable names, so I'd expect bs to handle that. If you could see if that's a recent regression that would be great, or if I can help let me know.

from observable.

tabatkins avatar tabatkins commented on June 1, 2024

Ah, yes, I was once again fooled by JS's replace function:

function nameFromVar(el) {
    return el.textContent.replace(/(\s|\xa0)+/, " ").trim();
}

That needs to be a global regex. :/

from observable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.