Comments (5)
Ah, nice find! OK I'll close this, and I assume bikeshed will get fixed at some point in the meantime? Thanks for the quick investigation!
from observable.
OK so it turns out that "visitor callback controller" is actually used, so this is a non-issue. It just looks like it is not used because bikeshed won't highlight all of the references to it inside the algorithm. That's really weird. @tabatkins do you know why this might be? If you go to https://wicg.github.io/observable/#:~:text=and%20signal%20abort-,visitor%20callback%20controller,-with%20E. and click that variable, notice that the instance of that variable in step 2 of that whole algorithm/div does not highlight...
from observable.
The immediate cause is that the final instance of the term is broken across the line in the source, so Bikeshed isn't recognizing it as the same term as the other two instances. But that's probably broken behavior; I should be normalizing whitespace. I wonder if that's a regression from my changes a few months ago?
from observable.
Oh interesting. Yeah I guess I'd expect that to still work? At least a lot of WHATWG standards are happy to break in the middle of variable names, so I'd expect bs to handle that. If you could see if that's a recent regression that would be great, or if I can help let me know.
from observable.
Ah, yes, I was once again fooled by JS's replace function:
function nameFromVar(el) {
return el.textContent.replace(/(\s|\xa0)+/, " ").trim();
}
That needs to be a global regex. :/
from observable.
Related Issues (20)
- Ability to destructure Subscriber HOT 2
- Spec's internal CSS sets colors without regard to dark mode HOT 2
- Priority list of operators HOT 6
- Minimal standalone polyfill of latest spec? HOT 1
- Spec: Document the "no exception was thrown" assertions
- Semantics of `do` (aka `tap` in many impls) HOT 7
- Should add the checking subscriber's `active` state to the first step of `next(value)`/`error(error)`/`complete()` methods? HOT 3
- Operator should not close its observable subscription on throwing error? HOT 3
- When elements are removed from the DOM HOT 1
- Data Sinks support
- cleanup: consider splitting "complete" vs "error" HOT 5
- Test suite HOT 1
- Separating signal from Observer
- Do we add `switchMap`? HOT 4
- Atomic transactions
- Please read the theory before fatal implementation HOT 2
- Standards tracking HOT 1
- Timing design options for `Promise`-returning operator abortion HOT 5
- Are IDL names like `Observer` too ambiguous? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from observable.