Crash when toggling a second (opposite) Y-Axis about react-jsx-highcharts HOT 7 CLOSED

Yes, that appears to be working in the actual application too. Looks good. Thanks for your help.

from react-jsx-highcharts.

Hmm interesting, and thanks for the reproducible test case!

I'll look into it, in the meantime, I think you could workaround the issue by using a title prop on the YAxis, instead of the child YAxis.Title component. It's a lot messier looking (in my opinion) but should unblock you.

<YAxis id="yAxisSecondary" title={{ text: 'Secondary' }} opposite>
  <LineSeries id='secondary' data={[ 5, 4, 3, 2, 1 ]}/>
</YAxis>

from react-jsx-highcharts.

Yes. Your workaround works. Thanks.

And I agree that your approach with the Title components is cleaner. Feels more idiomatic.

Thanks for all the great work on this, by the way. Very handy library.

from react-jsx-highcharts.

When I make that change I end up with a "double" opposite axis (i.e. the axis title and scale appear twice) and the opposite axis title remains when I disable that series. No console errors.

from react-jsx-highcharts.

Added the modified code as a gist:

https://gist.github.com/codingarmadillo/656e4a44b69fe3c48748f23d0fba0fce

from react-jsx-highcharts.

Oh dear, that's a bit rubbish. Seems the axis doesn't receive the remove function when it mounts, so it doesn't call it when it unmounts.

I think the Title sub component masked this second bug as it causes an axis update, which then caused the remove prop to be properly populated.

I'll investigate this urgently.

from react-jsx-highcharts.

Morning, so I've just published [email protected]. Would you mind verifying that it fixes your original issue? It fixes the slimmed down examples you provided.

from react-jsx-highcharts.