[BUG] Cannot find module 'typescript' about cjstoesm HOT 6 CLOSED

I just noted that you listed typescript as part of the deps

from cjstoesm.

Yes, typescript is a peer dependency and usage is documented here

from cjstoesm.

Hello,

required dependencies should be listed as dependencies and not as peerDependencies (source).

Please fix it accordingly.

Thanks

from cjstoesm.

@KaKi87,
Hi there.

I'm afraid you're misunderstanding or misinterpreting peer dependencies, how and when they're used, and why, including from the source you linked to.

The reason why libraries may declare a non-optional dependency as a peer dependency and not as a hard dependency is to allow consumers to use whatever version of the related package they want.

For optional peer dependencies, you can use peerDependenciesMeta and declare them as optional.

For example, if a library such as cjstoesm depended on something like typescript: ^4.6.3, that would force consumers of the library to depend on at least v.4.6.3 of TypeScript, even though they may be using another TypeScript version internally. Instead, cjstoesm supports any TypeScript version from v3.2 and up, and that makes it possible for you to use whatever TypeScript version you're targeting internally without being forced to update to the latest build.

from cjstoesm.

The reason why libraries may declare a non-optional dependency as a peer dependency and not as a hard dependency is to allow consumers to use whatever version of the related package they want.

Actually, the fact that your project would depend on a specific version of a package doesn't prevent the user from adding a different version of that package as a direct dependency.

EDIT: you could also use * if you wanted to make sure of it.

from cjstoesm.

Hi again.

Again, I want to reiterate that peer dependencies are not optional dependencies, as your comment seems to imply. You can, however, annotate them as such with peerDependenciesMeta as a library author if your package declares dependencies that the consuming user may only optionally install. TypeScript, however, is a required peer dependency of cjstoesm.

Please consult the official documentation or any of the existing great articles you can find online explaining when you may want to use peer dependencies, and when not to.

from cjstoesm.