android suggestions about flutter_wifi_connect HOT 3 CLOSED

Thanks @vipero07 for accepting my contribution and merging it so quickly!

Regarding permissions this is what I have so far and it is working fine on Android 8.1 and 11.0.

    <uses-permission android:name="android.permission.CHANGE_WIFI_STATE" />
    <uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
    <uses-permission android:name="android.permission.CHANGE_NETWORK_STATE" />
    <uses-permission android:name="android.permission.WRITE_SETTINGS" />

My understanding is that as long as we don't perform a wifi scan, or ask for the currently connected SSID (unless the connection was triggered by us. I think for the use case of IoT device pairing (which I believe it is also your use case) we will not need location permissions.

Please tag me once you publish a new version in pub.dev, in the meantime I'm referencing the commit hash.

from flutter_wifi_connect.

pub.dev has been updated to include your modifications.

On android pre 29 for it to connect to an ssid by prefix it does a wifi scan. So only in the case of having the exact ssid would it not require location permission. Unfortunately for me the device I'm dealing with is prefixed. However you are correct the other cases wouldn't require location permissions. Honestly it didn't occur to me. Thanks again for the insight.

from flutter_wifi_connect.

no need to discuss, I agree with your assessments. This was a quick prototype, so its nice to be able to move it forward. I plan on addressing some other issues I've come across, just been busy over the holiday season. Thanks a ton.

My only comment is regarding the location permissions on <29, I believe even with that change location permissions are still necessary due to the nature of connecting to alternative WIFI devices. However it would remove the requirement in the case of getSSID here https://github.com/HerbiaEra/flutter_wifi_connect/blob/6632122edb12b7293af596e7cd3e9c6fec5439f5/android/src/main/kotlin/com/weplenish/flutter_wifi_connect/FlutterWifiConnectPlugin.kt#L71 has i implemented it.

I'm sure you've noticed the primary reasons I didn't implement certain things in android is because there is no ability to implement them in iOS, so I've left a few things in limbo as a result.

from flutter_wifi_connect.