Home Page about project-daffodil HOT 14 OPEN

Hey I have tried to make some changes to the home page and fixed a bug can I do a PR?

from project-daffodil.

Done. Kindly review them.

from project-daffodil.

Hey I have tried to make some changes to the home page and fixed a bug can I do a PR?

@ghsayan share the screenshot of before and after

from project-daffodil.

Make the UI of home page better. Modify the layout for both dark mode and light mode .

Don't forget to include the before and after screenshots.

i want to give it a shot

from project-daffodil.

@Aniket762
Fixed a javascript file load issue and alignment on homepage, please accept my contribution. Thanks
Not sure how to share screenshots here.

from project-daffodil.

@Aniket762 I see my pull request was closed without merge or any comments. I did not make a large change because it might be too tricky to test or do a code review for.
Please do let me know if you are not looking for any outside contributions for this project

from project-daffodil.

Hey @ankitminglani, the changes were very minute and I felt it's not needed so closed the pull request. And yes outside collaborators can contribute. We would love to see the changes you make but first please let me know if you are interested and then I will assign it to you and then you can work on it.

from project-daffodil.

@Aniket762 I sent a pull request because i was interested in making more contributions to this project. I think a lot of good things can be done. Your readme.md file did not say anything that i have to be assigned an issue to work on it so i just sent a pull request which has worked fine for me with other projects.

In general practice, since this was my first commit to your project i would not want to make ground breaking changes so we both are comfortable working on it and have confidence of taking it to next level.

Do let me know your thoughts.

I did fix a very logical issue in your website. Bootstrap needs jQuery and jquery was loaded after bootstrap, so if you see you will get this error on console log , the site works after a split second once this is resolved by your browser.

The other minor fix was your section titles were touching the edge of the screen so i just aligned them so the site looks little professional.

I would understand if you still dont want to merge my code. The problem statement in the issue itself is sort of open ended.

from project-daffodil.

Sorry for the inconvenience @ankitminglani, your PR was so minor that it got marked as spam by our spammy bot. I have reopened it, kindly go through the revisions before we can merge it.

from project-daffodil.

Hey, I have tried to make a new layout for the home page.

following are the screenshots before and after.

Before:
[main-building]

[branches]

[course-info]

[resource]

[footer]

After:

[branches]

[course-info]

[resource]

Welcome your valuable feedback changes.

from project-daffodil.

Hey, @smalawad thanks for your effort it looks great but we don't want to change the UI of our homepage as of now.

from project-daffodil.

Thanks for your response!

May I know Is the issue still open? how can I contribute to it?

from project-daffodil.

@Aniket762 please assign this to me i can solve the issues or modify it

from project-daffodil.

@Aniket762 please assign this to me i can solve the issues or modify it

go for it

from project-daffodil.