Code Monkey home page Code Monkey logo

Comments (3)

scoiatael avatar scoiatael commented on July 23, 2024 1

Did some testing and looks like minimal size added by color conversion via Little-CMS would be around ~400kB:

 384K ┌── lcms.js 

So it looks like the best course is to simply expose information on color profile and let users take care of conversion.

Code and more compilation options are here.

from psd.

pastelmind avatar pastelmind commented on July 23, 2024

ICC color profiles are far beyond our interests--but if you can provide a PR, please go ahead! I can guarantee that no one (including myself) will be working on this for the foreseeable future.

That said, one of our goals is keeping the dependency count at zero. I also agree that having our own bindings would be better than importing another library. Either approach (full conversion VS simply exposing the raw data) is fine.

P. S. I am unfamiliar with ICC color profiles and color management. Could you briefly explain the value of this feature for me?

from psd.

scoiatael avatar scoiatael commented on July 23, 2024

First of all - I'm also not an expert. What I know is that OpenDesign should support this feature: around 6% of designs on our platform (or, at least 6% of designs in sample I use for testing) have non-standard ICC profile: adobeRGB and U.S. Web Coated (SWOP) v2 being the most common.

For these designs exported images are wrong - colors are off (for some less, for others more). For some reason I can't get it to work with open-source version of psd-tools, so here's comparison from our internal fork:

exported from Photoshop:

exported

psd-tools (internal):

gitlab-psd-tools

webtoon/psd:

webtoon


Main reason that SWOP is so off is that it's the only CMYK color mode in this comparison.

Also looks like there is a proposal to have colorSpace in ImageData.

from psd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.