Comments (5)
Thanks, I'd prefer fixes and test coverage in the downstream lib, let's await that first: mrmlnc/fast-glob#445
from knip.
Thanks for the bug report.
I wonder how it's possible the **/build
pattern matching files outside the pattern influences the results? Any chance a small explanation or even reproduction could be set up?
That might be a reason to either improve Knip's docs and/or implementation: perhaps by extending or doing something similar to the source mapping (dist/index.js
→ src/index.ts
) that was recently introduced.
from knip.
@webpro here it is: https://github.com/DaAitch/knip-issue-678
I simulated an absolute path, by checking in some folders.
The git-ignore rule builds/
in <PROJECT_ROOT>/Users/knipuser/cicd/builds/project42/.gitignore
is translated to a glob-ignore for **/builds/**
.
from knip.
Thanks, that helped a lot.
I think I found the issue, it seems to originate here in fast-glob: mrmlnc/fast-glob#441
Need to figure out whether it can/will be fixed downstream, or work around it in Knip.
from knip.
@webpro Okay interesting. Here is a red knip unit test DaAitch@5989d4a to reproduce
from knip.
Related Issues (20)
- False positives on Unresolved paths (repro in issue) HOT 3
- Namespace created from exports reporting that the exports are unused when using namespace imports HOT 5
- Report unnecessary exception tags as errors HOT 4
- graphql-codegen plugin doesn't handle plugins with plugin-specific config HOT 1
- False positives on Github CI with binaries + postcss inconsistency HOT 3
- False negatives in unused exports HOT 2
- Using Knip with `vite.config` HOT 1
- False negative with multiline exports HOT 2
- False negative when re-exporting HOT 4
- Object property enumeration methods used on enum reporting as unused exported enum members HOT 2
- [cypress] add support for cypress-multi-reporter HOT 1
- [jest] support nested jest config files HOT 3
- False positive on unused enum members when using multiple entrypoints + other conditions HOT 3
- False negative when name is used as property HOT 1
- Unused export inside exported namespace not reported HOT 5
- Provide a mechanism to skip reporting on specific unused files HOT 1
- False positives being reported on two packages HOT 1
- Exports previously legitimately reported as unused are no longer reported HOT 1
- All typescript interface files reported as Unused exported types HOT 4
- Unused assets are not reported HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from knip.