5.7.0: Failing to detect extensionless imports in some TS configurations. about knip HOT 7 CLOSED

Thanks for the report, but I don't seem to be able to access the repro.

from knip.

Sorry. I've fixed the permissions (hopefully…)
(I don't know much about codesandbox, but is it possible to have the links from knip's doc to pre-include most of the needed sharing options?)

from knip.

I'm seeing both foo.js and foo.ts in the same directory, is that intentional?

from knip.

Ah 💡 So you're saying that export * from "./foo" resolves as foo.js and thus considers foo.ts as ignored?

It is indeed my setup to keep everything in the same directory. This is for a library building and npm publish takes care of only bundling the *.js and *.d.ts files, so I don't need a separate dist directory.

from knip.

Ah 💡 So you're saying that export * from "./foo" resolves as foo.js and thus considers foo.ts as ignored?

Yeah, module resolution can only resolve to a single file, so the other will be ignored. There was a refactoring in module resolution, which was breaking for you for this reason.

It is indeed my setup to keep everything in the same directory. This is for a library building and npm publish takes care of only bundling the *.js and *.d.ts files, so I don't need a separate dist directory.

This is not common afaic, might be confusing for consumers of your lib. I would recommend to separate source and build/distribution artifacts.

Either way, it confuses Knip as it wants only source files. It supports both JS and TS so what's truth here?

from knip.

🤔 At least I understand where the problem comes from and why it's messy (modules resolutionS in JS is 🙄).

Maybe it is indeed time for a long overdue overhaul of my library structure… The setup form 2017 might not make that much sense now 😖

from knip.

Let's blame TypeScript for not setting the default value of outDir to e.g. ./dist/ :)

Going to close this one as "wontfix" or "invalid".

from knip.